Skip to content

Commit 7f0afad

Browse files
Merge pull request #379 from contentstack/rename-to-editInVisualBuilderButton
chore: rename `editButtonBulider` to `editInVisualBuilderButton`
2 parents ad2c8aa + 6d36acb commit 7f0afad

6 files changed

Lines changed: 23 additions & 22 deletions

File tree

docs/live-preview-configs.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,12 @@ ContentstackLivePreview.init({
124124
});
125125
```
126126

127-
### `editButtonBuilder`
128-
the editButtonBuilder object allows you to manage the "Start Editing" button outside Visual Builder. It offers the following features:
127+
### `editInVisualBuilderButton`
128+
the editInVisualBuilderButton object allows you to manage the "Start Editing" button outside Visual Builder. It offers the following features:
129129
- Enable/disable the "Start Editing" button
130130
- Adjust the position of the "Start Editing" button using four predefined positions
131131

132-
The editButtonBuilder object contains two keys:
132+
The editInVisualBuilderButton object contains two keys:
133133

134134
1. #### `enable`
135135
| type | default | optional |

src/configManager/config.default.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export function getUserInitData(): IInitData {
1616
position: "top",
1717
includeByQueryParameter: true,
1818
},
19-
editButtonBuilder: {
19+
editInVisualBuilderButton: {
2020
enable: true,
2121
position: "bottom-right"
2222
},
@@ -54,7 +54,7 @@ export function getDefaultConfig(): IConfig {
5454
position: "top",
5555
includeByQueryParameter: true,
5656
},
57-
editButtonBuilder: {
57+
editInVisualBuilderButton: {
5858
enable: true,
5959
position: "bottom-right"
6060
},

src/configManager/handleUserConfig.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ export const handleInitData = (initData: Partial<IInitData>): void => {
109109
true,
110110
});
111111

112-
Config.set("editButtonBuilder", {
112+
Config.set("editInVisualBuilderButton", {
113113
enable:
114-
initData.editButtonBuilder?.enable ??
115-
stackSdk.live_preview?.editButtonBuilder?.enable ??
116-
config.editButtonBuilder.enable,
114+
initData.editInVisualBuilderButton?.enable ??
115+
stackSdk.live_preview?.editInVisualBuilderButton?.enable ??
116+
config.editInVisualBuilderButton.enable,
117117
position:
118-
initData.editButtonBuilder?.position ??
118+
initData.editInVisualBuilderButton?.position ??
119119
stackSdk.live_preview?.position ??
120-
config.editButtonBuilder.position ??
120+
config.editInVisualBuilderButton.position ??
121121
"bottom-right",
122122
})
123123

src/types/types.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,15 @@ export declare interface IConfig {
7979
windowType: ILivePreviewWindowType;
8080
hash: string;
8181
editButton: IConfigEditButton;
82-
editButtonBuilder: IConfigEditButtonBuilder;
82+
editInVisualBuilderButton: IConfigEditInVisualBuilderButton;
8383
mode: ILivePreviewModeConfig;
8484
elements: {
8585
highlightedElement: HTMLElement | null;
8686
};
8787
}
8888

89-
export declare interface IConfigEditButtonBuilder {
89+
90+
export declare interface IConfigEditInVisualBuilderButton {
9091
enable: boolean;
9192
position?:
9293
| "top-left"
@@ -126,7 +127,7 @@ export declare interface IInitData {
126127
clientUrlParams: Partial<Omit<IClientUrlParams, "url">>;
127128
stackSdk: IStackSdk;
128129
editButton: IConfigEditButton;
129-
editButtonBuilder: IConfigEditButtonBuilder;
130+
editInVisualBuilderButton: IConfigEditInVisualBuilderButton;
130131
mode: ILivePreviewMode;
131132
}
132133

src/visualBuilder/components/__test__/startEditingButton.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ describe("StartEditingButtonComponent", () => {
4747
});
4848

4949
test("should not render when enable is false", async () => {
50-
Config.set("editButtonBuilder.enable", false);
50+
Config.set("editInVisualBuilderButton.enable", false);
5151
const { container } = await asyncRender(<StartEditingButtonComponent />);
5252
expect(container).toBeEmptyDOMElement();
5353
});
5454

5555
test("should render when enable is true", async () => {
56-
Config.set("editButtonBuilder.enable", true);
56+
Config.set("editInVisualBuilderButton.enable", true);
5757
const { getByTestId } = await asyncRender(<StartEditingButtonComponent />);
5858
const button = getByTestId("vcms-start-editing-btn");
5959
expect(button).toBeInTheDocument();
@@ -82,15 +82,15 @@ describe("StartEditingButtonComponent", () => {
8282
expect(getEditButtonPosition(invalidPosition)).toBe('bottom-right');
8383
});
8484

85-
test("should render with default values when editButtonBuilder config is missing", async () => {
85+
test("should render with default values when editInVisualBuilderButton config is missing", async () => {
8686
Config.reset();
8787
Config.set("stackDetails.apiKey", "bltapikey");
8888
Config.set("stackDetails.environment", "bltenvironment");
8989

9090
const { getByTestId } = await asyncRender(<StartEditingButtonComponent />);
9191
const button = getByTestId("vcms-start-editing-btn");
9292

93-
expect(Config.get().editButtonBuilder.position).toBe("bottom-right")
93+
expect(Config.get().editInVisualBuilderButton.position).toBe("bottom-right")
9494
expect(button).toBeInTheDocument();
9595
});
9696

src/visualBuilder/components/startEditingButton.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import { EditIcon } from "./icons";
44
import { visualBuilderStyles } from "../visualBuilder.style";
55
import React from "preact/compat";
66
import Config from "../../configManager/configManager";
7-
import { IConfigEditButtonBuilder } from "../../types/types";
7+
import { IConfigEditInVisualBuilderButton } from "../../types/types";
88

99

10-
type Position = NonNullable<IConfigEditButtonBuilder['position']>;
10+
type Position = NonNullable<IConfigEditInVisualBuilderButton['position']>;
1111

1212
const positionStyles: Record<Position, string> = {
1313
"bottom-right": visualBuilderStyles()['visual-builder__start-editing-btn__bottom-right'],
@@ -27,8 +27,8 @@ export function getEditButtonPosition(position: any): Position {
2727

2828
function StartEditingButtonComponent(): JSX.Element | null {
2929
const config = Config.get()
30-
const enable = config.editButtonBuilder.enable;
31-
const position = config.editButtonBuilder.position || "bottom-right";
30+
const enable = config.editInVisualBuilderButton.enable;
31+
const position = config.editInVisualBuilderButton.position || "bottom-right";
3232

3333
function updateTargetUrl(e: any){
3434
const targetElement = e.target as HTMLAnchorElement;

0 commit comments

Comments
 (0)