fix(field-toolbar): hide comment + field-location icons on read-restricted fields

VB-1541

Author: SahilCs15

src/visualBuilder/components/FieldToolbar.tsx

@@ -156,6 +156,7 @@ function FieldToolbarComponent(
     let disableFieldActions = false;
     let isCustomFieldMultipleInstance = false;
     let isCustomFieldWholeMultiple = false;
+    let isFieldReadRestricted = false;
     if (fieldSchema) {
         const { isDisabled } = isFieldDisabled(
             fieldSchema,
@@ -168,6 +169,7 @@ function FieldToolbarComponent(
             entryWorkflowStageDetails,
         );
         disableFieldActions = isDisabled;
+        isFieldReadRestricted = !!fieldSchema.field_metadata?.readRestrict;
 
         fieldType = getFieldType(fieldSchema);
 
@@ -595,7 +597,7 @@ function FieldToolbarComponent(
                                 {isModalEditable ? editButton : null}
                                 {isReplaceAllowed ? replaceButton : null}
                                 {formButton}
-                                {fieldSchema && !disableFieldActions ? (
+                                {fieldSchema && !isFieldReadRestricted ? (
                                     <CommentIcon
                                         fieldMetadata={fieldMetadata}
                                         fieldSchema={fieldSchema}
@@ -607,7 +609,7 @@ function FieldToolbarComponent(
                             </>
                         )}
 
-                        {!disableFieldActions && (
+                        {!isFieldReadRestricted && (
                             <FieldLocationIcon
                                 fieldLocationData={fieldLocationData}
                                 multipleFieldToolbarButtonClasses={

src/visualBuilder/components/__test__/fieldToolbar.test.tsx

@@ -321,11 +321,20 @@ describe("FieldToolbarComponent", () => {
             ).toBeInTheDocument();
         });
 
-        test("hides CommentIcon and FieldLocationIcon when field is disabled (update restrict)", async () => {
+        test("hides CommentIcon and FieldLocationIcon when field is read-restricted", async () => {
             vi.mocked(isFieldDisabled).mockReturnValue({
-                isDisabled: true,
-                reason: "You have only read access to this field" as any,
+                isDisabled: false,
+                reason: "" as any,
             });
+            vi.mocked(FieldSchemaMap.getFieldSchema).mockImplementation(() =>
+                Promise.resolve({
+                    ...mockMultipleLinkFieldSchema,
+                    field_metadata: {
+                        ...mockMultipleLinkFieldSchema.field_metadata,
+                        readRestrict: true,
+                    },
+                } as ISchemaFieldMap)
+            );
 
             const { container } = render(
                 <FieldToolbarComponent