Skip to content

Commit a42748d

Browse files
committed
Merge branch 'develop_v3' of https://github.com/contentstack/live-preview-sdk into VE-4043-configure-start-edit-retry-2
2 parents f9988a7 + 6cfe76f commit a42748d

3 files changed

Lines changed: 18 additions & 9 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ ContentstackLivePreview.init({
5151

5252
MIT License
5353

54-
Copyright © 2024 [Contentstack](https://www.contentstack.com/). All Rights Reserved
54+
Copyright © 2025 [Contentstack](https://www.contentstack.com/). All Rights Reserved
5555

5656
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
5757

src/visualBuilder/utils/__test__/handleIndividualFields.test.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,18 @@ describe("cleanIndividualFieldResidual", () => {
153153
expect(elements.resizeObserver.unobserve).toHaveBeenCalledWith(pseudoEditableElement);
154154
expect(pseudoEditableElement.parentNode).toBeNull();
155155
});
156-
157-
it("should clean focused toolbar correctly", () => {
158-
cleanIndividualFieldResidual(elements);
159-
160-
expect(elements.focusedToolbar?.innerHTML).toBe("");
161-
expect(visualBuilderPostMessage?.unregisterEvent).toHaveBeenCalledWith(VisualBuilderPostMessageEvents.DELETE_INSTANCE);
162-
expect(visualBuilderPostMessage?.unregisterEvent).toHaveBeenCalledWith(VisualBuilderPostMessageEvents.UPDATE_DISCUSSION_ID);
156+
it("should clean focused toolbar correctly", () => {
157+
cleanIndividualFieldResidual(elements);
158+
159+
expect(elements.focusedToolbar?.innerHTML).toBe("");
160+
161+
const toolbarEvents = [VisualBuilderPostMessageEvents.DELETE_INSTANCE, VisualBuilderPostMessageEvents.UPDATE_DISCUSSION_ID];
162+
toolbarEvents.forEach((event) => {
163+
//@ts-expect-error - We are accessing private method here, but it is necessary to clean up the event listeners.
164+
if (visualBuilderPostMessage?.requestMessageHandlers?.has(event)) {
165+
//@ts-expect-error - We are accessing private method here, but it is necessary to clean up the event listeners.
166+
expect(visualBuilderPostMessage?.unregisterEvent).toHaveBeenCalledWith(event);
167+
}
163168
});
169+
});
164170
});

src/visualBuilder/utils/handleIndividualFields.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,10 @@ export function cleanIndividualFieldResidual(elements: {
298298
const toolbarEvents = [VisualBuilderPostMessageEvents.DELETE_INSTANCE, VisualBuilderPostMessageEvents.UPDATE_DISCUSSION_ID]
299299
toolbarEvents.forEach((event) => {
300300
//@ts-expect-error - We are accessing private method here, but it is necessary to clean up the event listeners.
301-
visualBuilderPostMessage?.unregisterEvent?.(event);
301+
if (visualBuilderPostMessage?.requestMessageHandlers?.has(event)) {
302+
//@ts-expect-error - We are accessing private method here, but it is necessary to clean up the event listeners.
303+
visualBuilderPostMessage?.unregisterEvent?.(event);
304+
}
302305
});
303306
}
304307
}

0 commit comments

Comments
 (0)