Skip to content

Commit bbfcf29

Browse files
Merge remote-tracking branch 'origin/VB-694' into VB-694+sync
2 parents a915960 + b1db0fc commit bbfcf29

4 files changed

Lines changed: 16 additions & 10 deletions

File tree

src/visualBuilder/eventManager/__test__/useRevalidateFieldDataPostMessageEvent.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { vi, describe, it, expect, beforeEach, afterEach } from "vitest";
22
import { VisualBuilder } from "../..";
33
import { FieldSchemaMap } from "../../utils/fieldSchemaMap";
44
import { handleRevalidateFieldData } from "../useRevalidateFieldDataPostMessageEvent";
5-
5+
import * as cslpdata from "../../../cslp";
66
// Mock dependencies
77
vi.mock("../../utils/fieldSchemaMap", () => ({
88
FieldSchemaMap: {
@@ -11,9 +11,7 @@ vi.mock("../../utils/fieldSchemaMap", () => ({
1111
},
1212
}));
1313

14-
vi.mock("../../../cslp", () => ({
15-
extractDetailsFromCslp: vi.fn(),
16-
}));
14+
vi.spyOn(cslpdata, "extractDetailsFromCslp");
1715

1816
vi.mock("../../generators/generateOverlay", () => ({
1917
hideFocusOverlay: vi.fn(),

src/visualBuilder/eventManager/__test__/useVariantsPostMessageEvent.spec.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,9 @@ describe("useVariantFieldsPostMessageEvent", () => {
153153

154154
// Reset mocks
155155
vi.clearAllMocks();
156+
157+
// Mock isValidCslp to return true for test data (after clearAllMocks)
158+
vi.spyOn(cslpdata, "isValidCslp").mockReturnValue(true);
156159
});
157160

158161
afterEach(() => {
@@ -362,6 +365,9 @@ describe("addVariantFieldClass", () => {
362365

363366
// Reset mocks
364367
vi.clearAllMocks();
368+
369+
// Mock isValidCslp to return true for test data
370+
vi.spyOn(cslpdata, "isValidCslp").mockReturnValue(true);
365371
});
366372

367373
afterEach(() => {
@@ -423,6 +429,7 @@ describe("addVariantFieldClass", () => {
423429
variant: cslpValue.split(":")[1]
424430
}
425431
});
432+
426433
const variantUid = "variant-456";
427434
const variantOrder = ["variant-123", "variant-456"];
428435
VisualBuilder.VisualBuilderGlobalState.value.variantOrder = variantOrder;

src/visualBuilder/generators/__test__/generateOverlay.test.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { VisualBuilder } from "../..";
44
import { VisualBuilderPostMessageEvents } from "../../utils/types/postMessage.types";
55
import visualBuilderPostMessage from "../../utils/visualBuilderPostMessage";
66
import { FieldSchemaMap } from "../../utils/fieldSchemaMap";
7-
import { extractDetailsFromCslp } from "../../../cslp/cslpdata";
7+
import * as cslpdata from "../../../cslp/cslpdata";
88

99
vi.mock("../../utils/visualBuilderPostMessage", () => ({
1010
default: {
@@ -21,9 +21,7 @@ vi.mock("../../utils/fieldSchemaMap", () => ({
2121
},
2222
}));
2323

24-
vi.mock("../../../cslp/cslpdata", () => ({
25-
extractDetailsFromCslp: vi.fn(),
26-
}));
24+
vi.spyOn(cslpdata, "extractDetailsFromCslp");
2725

2826
describe("sendFieldEvent", () => {
2927
let previousSelectedEditableDOM: HTMLElement;
@@ -55,7 +53,7 @@ describe("sendFieldEvent", () => {
5553
eventType: VisualBuilderPostMessageEvents.UPDATE_FIELD,
5654
});
5755

58-
expect(extractDetailsFromCslp).not.toHaveBeenCalled();
56+
expect(cslpdata.extractDetailsFromCslp).not.toHaveBeenCalled();
5957
expect(FieldSchemaMap.getFieldSchema).not.toHaveBeenCalled();
6058
expect(visualBuilderPostMessage?.send).not.toHaveBeenCalled();
6159
});

src/visualBuilder/utils/__test__/getVisualBuilderRedirectionUrl.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { describe, it, expect, vi } from 'vitest';
22
import getVisualBuilderRedirectionUrl from '../getVisualBuilderRedirectionUrl';
33
import Config from '../../../configManager/configManager';
4-
import { extractDetailsFromCslp } from '../../../cslp';
4+
import { extractDetailsFromCslp, isValidCslp } from '../../../cslp';
55

66
vi.mock('../../../configManager/configManager');
77
vi.mock('../../../cslp');
@@ -61,6 +61,7 @@ describe('getVisualBuilderRedirectionUrl', () => {
6161
}
6262
});
6363

64+
isValidCslp.mockReturnValue(true);
6465
extractDetailsFromCslp.mockReturnValue({ locale: 'fr-FR' });
6566

6667
const result = getVisualBuilderRedirectionUrl();
@@ -99,6 +100,8 @@ describe('getVisualBuilderRedirectionUrl', () => {
99100
}
100101
});
101102

103+
isValidCslp.mockReturnValue(false);
104+
102105
const result = getVisualBuilderRedirectionUrl();
103106
// Should use locale from config when data-cslp attribute is invalid (empty or no value)
104107
expect(result.toString()).toBe('https://app.example.com/#!/stack/12345/visual-builder?branch=main&environment=production&target-url=https%3A%2F%2Fexample.com%2F&locale=en-US');

0 commit comments

Comments
 (0)