Skip to content

VE-5544: Investigate button click issue with data-cslp attribute#408

Merged
sairajchouhan merged 1 commit intodevelop_v3from
VE-5544-allow-click
Mar 28, 2025
Merged

VE-5544: Investigate button click issue with data-cslp attribute#408
sairajchouhan merged 1 commit intodevelop_v3from
VE-5544-allow-click

Conversation

@sairajchouhan
Copy link
Copy Markdown
Contributor

@sairajchouhan sairajchouhan commented Mar 25, 2025

when user clicks on an interactive element of the app in iframe with while holding the modifier key (in our case it is alt for windows, linux and option for macos) the clicks behaviour is not altered, which means interactive elements will be interactive while holding modifier key and clicking the element

@sairajchouhan sairajchouhan requested a review from a team as a code owner March 25, 2025 07:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the issue where clicking interactive elements with modifier keys in an iframe did not behave as expected. The changes introduce a conditional block to handle cases where the alt key is held, specifically altering behavior for anchor elements.

Comment thread src/visualBuilder/listeners/mouseClick.ts
@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 81.38% 6807 / 8364
🔵 Statements 81.38% 6807 / 8364
🔵 Functions 75.23% 243 / 323
🔵 Branches 85.5% 855 / 1000
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/listeners/mouseClick.ts 82.85% 83.33% 90.9% 82.85% 79-80, 83-88, 122-123, 168, 226-232, 252-258, 276-286
Generated in workflow #346 for commit 41dc8ad by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@sairajchouhan sairajchouhan merged commit 8f21238 into develop_v3 Mar 28, 2025
8 checks passed
@sairajchouhan sairajchouhan deleted the VE-5544-allow-click branch March 28, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants