VE-5544: Investigate button click issue with data-cslp attribute#408
Merged
sairajchouhan merged 1 commit intodevelop_v3from Mar 28, 2025
Merged
VE-5544: Investigate button click issue with data-cslp attribute#408sairajchouhan merged 1 commit intodevelop_v3from
data-cslp attribute#408sairajchouhan merged 1 commit intodevelop_v3from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where clicking interactive elements with modifier keys in an iframe did not behave as expected. The changes introduce a conditional block to handle cases where the alt key is held, specifically altering behavior for anchor elements.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when user clicks on an interactive element of the app in iframe with while holding the modifier key (in our case it is alt for windows, linux and option for macos) the clicks behaviour is not altered, which means interactive elements will be interactive while holding modifier key and clicking the element