fix(VE-4232): implement data-cslp mutation observer to manage unique IDs for elements#421
Merged
sairajchouhan merged 2 commits intodevelop_v3from Apr 15, 2025
Merged
fix(VE-4232): implement data-cslp mutation observer to manage unique IDs for elements#421sairajchouhan merged 2 commits intodevelop_v3from
sairajchouhan merged 2 commits intodevelop_v3from
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/visualBuilder/index.ts:450
- [nitpick] Consider adding a semicolon at the end of the disconnect call to maintain consistent coding style.
this.dataCslpMutationObserver.disconnect()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly adds a new attribute to all elements which has
data-cslptags which is used to uniquely identify an element in case of duplicate elements with samedata-cslptagshttps://contentstack.atlassian.net/browse/VE-4232
screenshot.14-04-2025-at-16.11.43.mp4