Skip to content

fix(VE-4232): implement data-cslp mutation observer to manage unique IDs for elements#421

Merged
sairajchouhan merged 2 commits intodevelop_v3from
VE-4232
Apr 15, 2025
Merged

fix(VE-4232): implement data-cslp mutation observer to manage unique IDs for elements#421
sairajchouhan merged 2 commits intodevelop_v3from
VE-4232

Conversation

@sairajchouhan
Copy link
Copy Markdown
Contributor

@sairajchouhan sairajchouhan commented Apr 14, 2025

This PR mainly adds a new attribute to all elements which has data-cslp tags which is used to uniquely identify an element in case of duplicate elements with same data-cslp tags

https://contentstack.atlassian.net/browse/VE-4232

screenshot.14-04-2025-at-16.11.43.mp4

@sairajchouhan sairajchouhan requested a review from a team as a code owner April 14, 2025 07:53
@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.9% 8135 / 11637
🔵 Statements 69.9% 8135 / 11637
🔵 Functions 68.03% 281 / 413
🔵 Branches 84.36% 977 / 1158
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/index.ts 52.64% 66.66% 42.85% 52.64% 92-99, 102-106, 109-121, 124-197, 203-237, 245-267, 272-300, 355-358, 361-362
src/visualBuilder/utils/updateFocussedState.ts 53.27% 54.16% 100% 53.27% 43, 55-57, 59-61, 63, 174-177, 179-210, 293-297, 300-317, 320-330, 333-350, 357-402, 409-431, 437-439
Generated in workflow #370 for commit f513fe5 by the Vitest Coverage Report Action

@sairajchouhan sairajchouhan changed the base branch from main to develop_v3 April 14, 2025 10:37
@sairajchouhan sairajchouhan requested a review from Copilot April 14, 2025 10:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/visualBuilder/index.ts:450

  • [nitpick] Consider adding a semicolon at the end of the disconnect call to maintain consistent coding style.
this.dataCslpMutationObserver.disconnect()

Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@sairajchouhan sairajchouhan merged commit 781d7ec into develop_v3 Apr 15, 2025
8 checks passed
@sairajchouhan sairajchouhan deleted the VE-4232 branch April 15, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants