fix(VE-5361): update field event is not sent when input event does not occur in inline editable fields#422
Merged
faraazb merged 5 commits intodevelop_v3from May 7, 2025
Merged
Conversation
…n inline editable fields A global state is used to track whether an input event was handled in the focussed field.
faraazb
requested review from
Copilot and
hiteshshetty-dev
and removed request for
a team
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/visualBuilder/index.ts:52
- [nitpick] Consider renaming 'focusFieldReceivedInput' to a shorter, more concise name (e.g. 'hasReceivedInput') for improved readability.
focusFieldReceivedInput: boolean;
src/visualBuilder/generators/generateOverlay.tsx:141
- Ensure that resetting 'focusFieldReceivedInput' to false immediately after sending the field event does not inadvertently suppress subsequent events in asynchronous scenarios; consider deferring the reset until confirmation that the event has been processed.
VisualBuilder.VisualBuilderGlobalState.value.focusFieldReceivedInput = false;
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
If no input was received on the contenteditable, but the value updated through preview data, as noTrigger was false, we would revert the field value to the previous one through the else clause.
Contributor
hiteshshetty-dev
left a comment
hiteshshetty-dev
left a comment
There was a problem hiding this comment.
Changes look good to me!! Please add unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.