Skip to content

fix(VE-5803): sync field after custom space handling#427

Merged
faraazb merged 2 commits intodevelop_v3from
VE-5803-space-key-element-inside-button
Apr 21, 2025
Merged

fix(VE-5803): sync field after custom space handling#427
faraazb merged 2 commits intodevelop_v3from
VE-5803-space-key-element-inside-button

Conversation

@faraazb
Copy link
Copy Markdown
Contributor

@faraazb faraazb commented Apr 21, 2025

Since we prevent default (input) behaviour while we handle the space keydown, we must send the sync event which is sent while handling the input event

@faraazb faraazb requested a review from a team as a code owner April 21, 2025 07:19
Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.92% 8143 / 11645
🔵 Statements 69.92% 8143 / 11645
🔵 Functions 68.03% 281 / 413
🔵 Branches 84.4% 980 / 1161
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/utils/handleFieldMouseDown.ts 100% 92.59% 100% 100%
Generated in workflow #382 for commit fd886ac by the Vitest Coverage Report Action

@faraazb faraazb merged commit 332cebb into develop_v3 Apr 21, 2025
8 checks passed
@faraazb faraazb deleted the VE-5803-space-key-element-inside-button branch April 21, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants