Skip to content

fix: update LightLivePreviewHoC config to use IExportedConfig type#438

Merged
KANE-99 merged 7 commits intodevelop_v3from
VE-6414-fix-contentstack-live-preview-sd-ks-config-type
May 26, 2025
Merged

fix: update LightLivePreviewHoC config to use IExportedConfig type#438
KANE-99 merged 7 commits intodevelop_v3from
VE-6414-fix-contentstack-live-preview-sd-ks-config-type

Conversation

@KANE-99
Copy link
Copy Markdown

@KANE-99 KANE-99 commented May 26, 2025

No description provided.

@KANE-99 KANE-99 requested a review from a team as a code owner May 26, 2025 11:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the LightLivePreviewHoC configuration by importing and using the IExportedConfig type.

  • Updated import to include IExportedConfig
  • Changed the config getter to cast the returned object as IExportedConfig

Comment thread src/index.ts Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.09% 8426 / 11851
🔵 Statements 71.09% 8426 / 11851
🔵 Functions 71.12% 298 / 419
🔵 Branches 85.15% 1050 / 1233
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/index.ts 100% 100% 100% 100%
src/light-sdk.ts 95.65% 100% 90% 95.65% 38-39
Generated in workflow #416 for commit 45c8c99 by the Vitest Coverage Report Action

@KANE-99 KANE-99 changed the base branch from main to develop_v3 May 26, 2025 12:43
Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KANE-99 KANE-99 merged commit 2a7e562 into develop_v3 May 26, 2025
10 checks passed
@KANE-99 KANE-99 deleted the VE-6414-fix-contentstack-live-preview-sd-ks-config-type branch May 26, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants