Skip to content

VE-6559:add isOpenInBuilder utility function and integrate into VisualBuilder components#446

Merged
SahilCs15 merged 1 commit intodevelop_v3from
VE-6559-conditionally-render-visual-builder-ui-elements-and-hide-when-not-in-use
Jun 16, 2025
Merged

VE-6559:add isOpenInBuilder utility function and integrate into VisualBuilder components#446
SahilCs15 merged 1 commit intodevelop_v3from
VE-6559-conditionally-render-visual-builder-ui-elements-and-hide-when-not-in-use

Conversation

@SahilCs15
Copy link
Copy Markdown
Contributor

This PR adds a check while weather we are inside VB or LP and based on that conditionally render the VB components

@SahilCs15 SahilCs15 requested a review from a team as a code owner June 13, 2025 14:55
@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.11% 8438 / 11865
🔵 Statements 71.11% 8438 / 11865
🔵 Functions 71.19% 299 / 420
🔵 Branches 85.13% 1054 / 1238
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/utils/index.ts 88.57% 71.42% 100% 88.57% 29-30, 38-39
src/visualBuilder/components/VisualBuilder.tsx 100% 100% 100% 100%
src/visualBuilder/components/index.tsx 100% 100% 100% 100%
Generated in workflow #434 for commit 8e80517 by the Vitest Coverage Report Action

Comment thread src/visualBuilder/__test__/index.test.ts
KANE-99
KANE-99 previously approved these changes Jun 16, 2025
Copy link
Copy Markdown

@KANE-99 KANE-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SahilCs15 SahilCs15 changed the base branch from main to develop_v2 June 16, 2025 08:15
@SahilCs15 SahilCs15 changed the base branch from develop_v2 to main June 16, 2025 08:16
@SahilCs15 SahilCs15 dismissed KANE-99’s stale review June 16, 2025 08:16

The base branch was changed.

@SahilCs15 SahilCs15 changed the base branch from main to develop_v3 June 16, 2025 08:18
@SahilCs15 SahilCs15 merged commit d1b5b32 into develop_v3 Jun 16, 2025
10 checks passed
@SahilCs15 SahilCs15 deleted the VE-6559-conditionally-render-visual-builder-ui-elements-and-hide-when-not-in-use branch June 16, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants