Skip to content

fix: start editing button not rendering#447

Merged
SahilCs15 merged 1 commit intodevelop_v3from
start-editing-button-not-rendering
Jun 25, 2025
Merged

fix: start editing button not rendering#447
SahilCs15 merged 1 commit intodevelop_v3from
start-editing-button-not-rendering

Conversation

@SahilCs15
Copy link
Copy Markdown
Contributor

The start editing button was not getting rendered as it was loaded inside the visual-builder_container which was only visible inside the visual builder

@SahilCs15 SahilCs15 requested a review from a team as a code owner June 25, 2025 06:07
Copy link
Copy Markdown

@KANE-99 KANE-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 25, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.37% 8598 / 11880
🔵 Statements 72.37% 8598 / 11880
🔵 Functions 71.76% 305 / 425
🔵 Branches 84.82% 1068 / 1259
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/index.ts 56.86% 66.66% 42.85% 56.86% 94-101, 104-108, 111-123, 126-199, 205-237, 245-267, 318-321, 324-325
src/visualBuilder/generators/generateStartEditingButton.tsx 89.47% 80% 100% 89.47% 23-24
Generated in workflow #435 for commit f690285 by the Vitest Coverage Report Action

@SahilCs15 SahilCs15 merged commit 856cd9c into develop_v3 Jun 25, 2025
10 of 12 checks passed
@SahilCs15 SahilCs15 deleted the start-editing-button-not-rendering branch June 25, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants