Optimisation: init to emit postMessage on DOMContentLoaded#448
Merged
csAyushDubey merged 2 commits intodevelop_v3from Jul 1, 2025
Merged
Optimisation: init to emit postMessage on DOMContentLoaded#448csAyushDubey merged 2 commits intodevelop_v3from
init to emit postMessage on DOMContentLoaded#448csAyushDubey merged 2 commits intodevelop_v3from
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
hiteshshetty-dev
left a comment
hiteshshetty-dev
left a comment
There was a problem hiding this comment.
@csAyushDubey Have we tested on CSR and SSR apps?
Contributor
Author
|
@hiteshshetty-dev Yes I've tested on both builds, CSR through CRA and SSR through Next, I've attached video recordings in the Confluence |
hiteshshetty-dev
approved these changes
Jul 1, 2025
Contributor
hiteshshetty-dev
left a comment
hiteshshetty-dev
left a comment
There was a problem hiding this comment.
Changes looks good to me!!
Please check with @altsh-cs for QA testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check: https://contentstack.atlassian.net/wiki/spaces/VC/pages/3453943812/Live+Preview+SDK+init+optimisation