Skip to content

Field modifiers in canvas#449

Merged
sairajchouhan merged 5 commits intoVE-5474-Field-Modifier-support-for-canvas-in-Visual-Builderfrom
Field-modifiers-in-canvas
Jul 7, 2025
Merged

Field modifiers in canvas#449
sairajchouhan merged 5 commits intoVE-5474-Field-Modifier-support-for-canvas-in-Visual-Builderfrom
Field-modifiers-in-canvas

Conversation

@SahilCs15
Copy link
Copy Markdown
Contributor

This PR adds support of field modifier rendering on the canvas and when the field modifier is selected it sends the data including the add details and the position of the toolbar

@SahilCs15 SahilCs15 requested a review from a team as a code owner July 1, 2025 13:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.71% 8874 / 12203
🔵 Statements 72.71% 8874 / 12203
🔵 Functions 71.46% 313 / 438
🔵 Branches 84.8% 1094 / 1290
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/visualBuilder.style.ts 100% 100% 100% 100%
src/visualBuilder/components/FieldLocationAppList.tsx 94.2% 92.3% 100% 94.2% 174-182
src/visualBuilder/components/FieldLocationIcon.tsx 83.87% 100% 33.33% 83.87% 31-36, 56-59
src/visualBuilder/components/FieldToolbar.tsx 77.46% 74.46% 33.33% 77.46% 63-111, 133, 172, 202-219, 240-243, 266-275, 304-312, 320-321, 324-325, 377-383, 395-396, 461, 498, 578-582
src/visualBuilder/components/icons/EmptyAppIcon.tsx 100% 100% 100% 100%
src/visualBuilder/components/icons/index.tsx 82.5% 94.44% 86.66% 82.5% 208-232, 284-310
src/visualBuilder/utils/handleIndividualFields.ts 96.94% 80% 100% 96.94% 93-94, 173-174
src/visualBuilder/utils/types/postMessage.types.ts 100% 100% 100% 100%
Generated in workflow #439 for commit a0ff5b0 by the Vitest Coverage Report Action

Comment thread src/visualBuilder/components/FieldToolbar.tsx
@sairajchouhan sairajchouhan self-requested a review July 3, 2025 06:28
Copy link
Copy Markdown
Contributor

@sairajchouhan sairajchouhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found few issues after running the app locally

  1. the app icon looks small in field toolbar
    Image

  2. if user only has 1 app installed lets not even show the button to open dropdown

Image

@sairajchouhan sairajchouhan self-requested a review July 3, 2025 13:17
Copy link
Copy Markdown
Contributor

@sairajchouhan sairajchouhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sairajchouhan sairajchouhan merged commit d2c1c70 into VE-5474-Field-Modifier-support-for-canvas-in-Visual-Builder Jul 7, 2025
9 of 11 checks passed
@sairajchouhan sairajchouhan deleted the Field-modifiers-in-canvas branch July 7, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants