[Feature] HoverToolbar#455
Conversation
[Feat: HoverToolbar] Component and rendering logic changes
[HoverToolbar]: Handling postMessage for ReferenceParentMap and rendering changes
| <></> | ||
| ), | ||
| isReference, | ||
| isEmbedded: false, |
There was a problem hiding this comment.
When do we set isEmbeded as true?
There was a problem hiding this comment.
no was added when we were considering a different Icon for embeded entries, not needed now
Had removed it in a cleanup commit, missed to push that commit
| visualBuilderPostMessage?.on<ReferenceMapPostMessageEventData>( | ||
| VisualBuilderPostMessageEvents.REFERENCE_MAP, | ||
| (event) => { | ||
| console.log("REFERENCE_MAP", event.data); |
There was a problem hiding this comment.
This is expected?
There was a problem hiding this comment.
no not needed, pushed the cleanup commit
| ) as HTMLDivElement | null; | ||
| const { editableElement: targetElement, fieldMetadata } = eventDetails; | ||
|
|
||
| if (fieldLabelWrapper) { |
There was a problem hiding this comment.
| if (fieldLabelWrapper) { | |
| if (fieldLabelWrapper && isHover){ |
There was a problem hiding this comment.
Actually here I want to go in the if block if it is fieldLabelWrapper irrespective of if it is isHover, inside the if block I handle hover state and focus state differently
Suggested change would result in more that one focus toolbars
| export interface ReferenceMapPostMessageEventData { | ||
|
|
||
| } No newline at end of file |
There was a problem hiding this comment.
Is this expected?
There was a problem hiding this comment.
no, part of the cleanup commit
[Feature] HoverToolbar
[Feature] HoverToolbar
2 participants
Title
This adds HoverToolbar feature support to SDK
Description
It does the following few things:
SS
Screen.Recording.2025-07-10.at.12.00.42.PM.mov