VE-6721:Render field modifer in canvas#456
Closed
SahilCs15 wants to merge 2 commits intoVE-5474-Field-Modifier-support-for-canvas-in-Visual-Builderfrom
Closed
VE-6721:Render field modifer in canvas#456SahilCs15 wants to merge 2 commits intoVE-5474-Field-Modifier-support-for-canvas-in-Visual-Builderfrom
SahilCs15 wants to merge 2 commits intoVE-5474-Field-Modifier-support-for-canvas-in-Visual-Builderfrom
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
faraazb
reviewed
Jul 14, 2025
| toolbarRef={toolbarRef} | ||
| apps={fieldLocationData?.apps || ([] as any[])} | ||
| position={appListPosition} | ||
| domEditStack={fieldLocationData.DomEditStack} |
Contributor
There was a problem hiding this comment.
We should not need the DomEditStack from the builder, we have this data here itself right?
faraazb
approved these changes
Jul 14, 2025
Contributor
faraazb
left a comment
faraazb
left a comment
There was a problem hiding this comment.
Looks good! Just a common comment on VB and SDK side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to https://github.com/contentstack/visual-builder/pull/1518 change in VB