Skip to content

VE-6721:Render field modifer in canvas #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SahilCs15 wants to merge 2 commits into from
Closed

VE-6721:Render field modifer in canvas #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a81a4
redner the app on dom
SahilCs15 Jul 9, 2025
14ba432
fix:removed uncessary changes
SahilCs15 Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/visualBuilder/components/FieldLocationAppList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { VisualBuilderPostMessageEvents } from "../utils/types/postMessage.types
import visualBuilderPostMessage from "../utils/visualBuilderPostMessage";
import { visualBuilderStyles } from "../visualBuilder.style";
import classNames from "classnames";
import { CslpData } from "../../utils/cslpdata";

interface App {
app_installation_uid: string;
Expand All @@ -30,6 +31,9 @@ interface FieldLocationAppListProps {
apps: App[];
position: "left" | "right";
toolbarRef: React.RefObject<HTMLDivElement>;
domEditStack:CslpData[]
setDisplayAllApps: (displayAllApps: boolean) => void;
displayAllApps: boolean;
}

const normalize = (text: string) =>
Expand All @@ -42,6 +46,8 @@ export const FieldLocationAppList = ({
apps,
position,
toolbarRef,
domEditStack,
setDisplayAllApps,
}: FieldLocationAppListProps) => {
const remainingApps = apps.filter((app, index) => index !== 0);
const [search, setSearch] = useState("");
Expand All @@ -63,8 +69,10 @@ export const FieldLocationAppList = ({
{
app: app,
position: toolbarRef.current?.getBoundingClientRect(),
DomEditStack:domEditStack
}
);
setDisplayAllApps(false);
};

return (
Expand Down
1 change: 1 addition & 0 deletions src/visualBuilder/components/FieldLocationIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const FieldLocationIcon = ({
visualBuilderPostMessage?.send(VisualBuilderPostMessageEvents.FIELD_LOCATION_SELECTED_APP, {
app,
position: toolbarRef.current?.getBoundingClientRect(),
DomEditStack:fieldLocationData.DomEditStack
});
};

Expand Down
3 changes: 3 additions & 0 deletions src/visualBuilder/components/FieldToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,9 @@ function FieldToolbarComponent(
toolbarRef={toolbarRef}
apps={fieldLocationData?.apps || ([] as any[])}
position={appListPosition}
domEditStack={fieldLocationData.DomEditStack}
Copy link
Copy Markdown
Contributor

@faraazb faraazb Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need the DomEditStack from the builder, we have this data here itself right?

setDisplayAllApps={setDisplayAllApps}
displayAllApps={displayAllApps}
/>
)}
</div>
Expand Down
14 changes: 13 additions & 1 deletion src/visualBuilder/components/__test__/FieldLocationAppList.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,17 +145,29 @@ describe("FieldLocationAppList", () => {
});

it("should send event when app is clicked", () => {
render(<FieldLocationAppList apps={mockApps} position="right" toolbarRef={mockToolbarRef} />);
const mockSetDisplayAllApps = vi.fn();
render(<FieldLocationAppList apps={mockApps} position="right" toolbarRef={mockToolbarRef} domEditStack={[]} setDisplayAllApps={mockSetDisplayAllApps} displayAllApps={true} />);

const secondApp = screen.getByText("Second App");
fireEvent.click(secondApp);

expect(visualBuilderPostMessage?.send).toHaveBeenCalledWith("field-location-selected-app", {
app: mockApps[1],
position: { top: 0, left: 0, right: 100, bottom: 50, width: 100, height: 50, x: 0, y: 0 },
DomEditStack: []
});
});

it("should close the app list when an app is selected", () => {
const mockSetDisplayAllApps = vi.fn();
render(<FieldLocationAppList apps={mockApps} position="right" toolbarRef={mockToolbarRef} domEditStack={[]} setDisplayAllApps={mockSetDisplayAllApps} displayAllApps={true} />);

const secondApp = screen.getByText("Second App");
fireEvent.click(secondApp);

expect(mockSetDisplayAllApps).toHaveBeenCalledWith(false);
});




Expand Down
Loading