Skip to content

fix: multiple reloads in timeline#457

Closed
contentstackMridul wants to merge 3 commits intodevelop_v3from
VE_6673
Closed

fix: multiple reloads in timeline#457
contentstackMridul wants to merge 3 commits intodevelop_v3from
VE_6673

Conversation

@contentstackMridul
Copy link
Copy Markdown
Contributor

fix: multiple reloads in timeline
Ticket -> https://contentstack.atlassian.net/browse/VE-6673
Test Report ->
Screenshot 2025-07-11 at 16 43 01

This pull request introduces enhancements to the live preview functionality, focusing on improving query parameter handling, adding support for timeline-specific behavior, and refining event listener logic. The most important changes include updates to query parameter management, adjustments to event handling, and integration of timeline-specific checks.

Query Parameter Handling Enhancements:

  • src/utils/addLivePreviewQueryTags.ts: Added support for the preview_timestamp query parameter and refined logic for adding live_preview, content_type_uid, and entry_uid query parameters.
  • src/utils/index.ts: Improved handling of click events by ensuring query parameters are added only to valid anchor elements and their descendants.

Timeline-Specific Behavior:

Event Listener Refinements:

@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.37% 8618 / 11907
🔵 Statements 72.37% 8618 / 11907
🔵 Functions 71.83% 306 / 426
🔵 Branches 84.7% 1074 / 1268
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/livePreview/eventManager/postMessageEvent.hooks.ts 83.69% 76.47% 75% 83.69% 34-36, 83-84, 97, 106, 119-127
src/utils/addLivePreviewQueryTags.ts 74.07% 50% 100% 74.07% 13-14, 16-18, 20-21
src/utils/index.ts 84.61% 62.5% 100% 84.61% 15-16, 36-37, 45-46
Generated in workflow #454 for commit e335877 by the Vitest Coverage Report Action

Comment thread src/utils/index.ts
Copy link
Copy Markdown

@KANE-99 KANE-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants