Skip to content

Disable scroll when field modifer is active#458

Merged
SahilCs15 merged 5 commits intoVE-5474-Field-Modifier-support-for-canvas-in-Visual-Builderfrom
disable-scroll-when-field-modifer-is-active
Jul 15, 2025
Merged

Disable scroll when field modifer is active#458
SahilCs15 merged 5 commits intoVE-5474-Field-Modifier-support-for-canvas-in-Visual-Builderfrom
disable-scroll-when-field-modifer-is-active

Conversation

@SahilCs15
Copy link
Copy Markdown
Contributor

This PR added support to disable scroll when field modifier is open

@SahilCs15 SahilCs15 requested a review from a team as a code owner July 11, 2025 11:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 11, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.67% 8885 / 12225
🔵 Statements 72.67% 8885 / 12225
🔵 Functions 71.68% 314 / 438
🔵 Branches 84.72% 1093 / 1290
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/index.ts 56.32% 66.66% 42.85% 56.32% 94-101, 104-108, 111-123, 126-199, 205-237, 245-267, 318-321, 324-325, 375-380
src/visualBuilder/components/FieldLocationAppList.tsx 94.36% 92.3% 100% 94.36% 182-190
src/visualBuilder/components/FieldLocationIcon.tsx 82.81% 100% 33.33% 82.81% 34-40, 60-63
src/visualBuilder/components/FieldToolbar.tsx 77.07% 74.46% 33.33% 77.07% 64-112, 134, 173, 206-223, 244-247, 270-279, 308-316, 324-325, 328-329, 381-387, 399-400, 465, 502, 583-590
src/visualBuilder/utils/types/postMessage.types.ts 100% 100% 100% 100%
Generated in workflow #456 for commit 12be298 by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@csAyushDubey csAyushDubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csAyushDubey
Copy link
Copy Markdown
Contributor

Please fix test cases before merging.

@SahilCs15 SahilCs15 merged commit cd63458 into VE-5474-Field-Modifier-support-for-canvas-in-Visual-Builder Jul 15, 2025
9 of 11 checks passed
@SahilCs15 SahilCs15 deleted the disable-scroll-when-field-modifer-is-active branch July 15, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants