Skip to content

chore(VE-6918/error-text): warning message improved#459

Closed
csAdityaPachauri wants to merge 16 commits intodevelop_v3from
VE-6918/error-text
Closed

chore(VE-6918/error-text): warning message improved#459
csAdityaPachauri wants to merge 16 commits intodevelop_v3from
VE-6918/error-text

Conversation

@csAdityaPachauri
Copy link
Copy Markdown
Contributor

@csAdityaPachauri csAdityaPachauri commented Jul 15, 2025 •
edited
Loading

Fix Font Awesome icon styling and vertical alignment issues

Issue Background:

The Font Awesome icon (fas fa-plus) was not rendering correctly because:

  • No Font Awesome dependency in the project's package.json
  • Relied on external dependency - the icon was likely working due to Font Awesome being included as a starter dependency in consuming applications
  • Inconsistent rendering across different environments where Font Awesome wasn't available
Screenshot 2025-07-21 at 5 23 15 PM

@csAdityaPachauri csAdityaPachauri requested a review from a team as a code owner July 15, 2025 09:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 15, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.14% 9076 / 12581
🔵 Statements 72.14% 9076 / 12581
🔵 Functions 71.96% 326 / 453
🔵 Branches 84.22% 1132 / 1344
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/visualBuilder.style.ts 100% 100% 100% 100%
src/visualBuilder/components/emptyBlock.tsx 100% 100% 100% 100%
src/visualBuilder/components/icons/index.tsx 75.08% 94.11% 75% 75.08% 210-234, 286-312, 315-329, 332-344
src/visualBuilder/generators/generateToolbar.tsx 89.72% 86.66% 83.33% 89.72% 28-29, 87-92, 140-144, 186-187
src/visualBuilder/listeners/mouseHover.ts 61.37% 50% 62.5% 61.37% 52-59, 76-77, 94-97, 127-137, 143-144, 151-154, 157-159, 165, 179-180, 189-201, 208-210, 212-253, 261-263, 265-267, 275-283, 286-290, 292, 294-296, 311-315, 337-340
src/visualBuilder/utils/types/postMessage.types.ts 100% 100% 100% 100%
Generated in workflow #492 for commit 04f22dd by the Vitest Coverage Report Action

@sairajchouhan sairajchouhan changed the base branch from main to develop_v3 July 17, 2025 07:43
hiteshshetty-dev
hiteshshetty-dev approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

sairajchouhan
sairajchouhan requested changes Jul 21, 2025
View reviewed changes
Comment thread src/visualBuilder/components/emptyBlock.tsx Outdated
Comment thread src/visualBuilder/components/emptyBlock.tsx
csAyushDubey
csAyushDubey previously approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@csAyushDubey csAyushDubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

hiteshshetty-dev
hiteshshetty-dev previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

csAdityaPachauri and others added 11 commits July 23, 2025 14:17
@csAdityaPachauri
Merge branch 'develop_v3' of https://github.com/contentstack/live-pre…
a273355 
…view-sdk into VE-6918/error-text
@csAdityaPachauri
chore(talismanrc): updated
5084bb3
@csAyushDubey @csAdityaPachauri
Merge pull request #455 from contentstack/VE-6600-Hover-Toolbar-Support
699f81c 
[Feature] HoverToolbar
@csAyushDubey @csAdityaPachauri
Merge pull request #464 from contentstack/VE-6600-Hover-Toolbar-Support
7146855 
HoverToolbar: Requested Changes
@csAyushDubey @csAdityaPachauri
Merge pull request #461 from contentstack/VE-6600-Hover-Toolbar-Support
f6939b1 
Fix: HoverToolbar to not render when focussed
@sairaj-cs
Merge pull request #473 from contentstack/release-24-jul-main
11c9812 
Release 24 July to stage_v3
@csAdityaPachauri
chore:increment package version
950170c
@csAdityaPachauri
Merge branch 'main' into stage_v3
71913fb
@sairaj-cs
Merge pull request #474 from contentstack/stage_v3
95fb850 
v3.3.0
@csAdityaPachauri
chore(VE-6918/error-text): unit test file added
3a21b82
@csAdityaPachauri
Merge branch 'main' of https://github.com/contentstack/live-preview-sdk…
04f22dd 
… into VE-6918/error-text
@csAdityaPachauri csAdityaPachauri changed the base branch from develop_v3 to main July 30, 2025 07:24
@csAdityaPachauri csAdityaPachauri dismissed stale reviews from hiteshshetty-dev and csAyushDubey July 30, 2025 07:24

The base branch was changed.

@csAdityaPachauri csAdityaPachauri changed the base branch from main to develop_v3 July 30, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sairajchouhan sairajchouhan sairajchouhan requested changes

@hiteshshetty-dev hiteshshetty-dev hiteshshetty-dev left review comments

@faraazb faraazb Awaiting requested review from faraazb

+2 more reviewers

@AdityyaX AdityyaX AdityyaX left review comments

@csAyushDubey csAyushDubey csAyushDubey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@csAdityaPachauri @hiteshshetty-dev @sairajchouhan @AdityyaX @csAyushDubey @karancs06 @sairaj-cs