Ve 5474 field modifier support for canvas in visual builder#460
Merged
SahilCs15 merged 16 commits intodevelop_v3from Jul 16, 2025
Merged
Conversation
… the selected app
Field modifiers in canvas
…en-field-modifer-is-active
…odifer-is-active Disable scroll when field modifer is active
…vas-in-Visual-Builder
SahilCs15
requested review from
csAyushDubey,
faraazb,
hiteshshetty-dev and
sairajchouhan
faraazb
suggested changes
Jul 16, 2025
|
|
||
|
|
||
|
|
||
| if (!fieldLocationData?.apps || fieldLocationData.apps.length === 0) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!fieldLocationData?.apps || fieldLocationData.apps.length === 0) { | |
| if (!fieldLocationData?.apps || fieldLocationData?.apps?.length === 0) { |
| expect(appList).toHaveClass("visual-builder__field-location-app-list"); | ||
| }); | ||
|
|
||
| it("should apply correct CSS classes for left position", () => { |
Contributor
There was a problem hiding this comment.
Please check how can we better test left/right configuration
Contributor
Author
There was a problem hiding this comment.
now it checks visual-builder__field-location-app-list-left and visual-builder__field-location-app-list-right
| expect(appList).toHaveClass("visual-builder__field-location-app-list"); | ||
| }); | ||
|
|
||
| it("should handle empty apps array", () => { |
Contributor
There was a problem hiding this comment.
Please check this if we are hiding the More icon when there is one app or no apps.
Contributor
Author
There was a problem hiding this comment.
this case it not applicable we were rendering the FieldLocationApplist which will not happen if we do not have any apps
| } | ||
| }); | ||
|
|
||
| describe("Field Location Dropdown", () => { |
Contributor
There was a problem hiding this comment.
We can move these tests to the FieldLocationIcon.test.tsx file
SahilCs15
deleted the
VE-5474-Field-Modifier-support-for-canvas-in-Visual-Builder
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added support for field modifer in canvas