Skip to content

Fix: HoverToolbar to not render when focussed#461

Merged
csAyushDubey merged 1 commit intodevelop_v3from
VE-6600-Hover-Toolbar-Support
Jul 16, 2025
Merged

Fix: HoverToolbar to not render when focussed#461
csAyushDubey merged 1 commit intodevelop_v3from
VE-6600-Hover-Toolbar-Support

Conversation

@csAyushDubey
Copy link
Copy Markdown
Contributor

Found this issue while manual testing, when a container content is focussed -> hovering on any child content was changing the toolbar content => Fixed this

@csAyushDubey csAyushDubey requested a review from a team as a code owner July 16, 2025 09:58
Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.78% 9026 / 12574
🔵 Statements 71.78% 9026 / 12574
🔵 Functions 71.61% 323 / 451
🔵 Branches 84.17% 1128 / 1340
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/index.ts 56.87% 66.66% 42.85% 56.87% 98-105, 108-112, 115-127, 130-203, 209-241, 249-271, 322-325, 328-329, 379-384
src/visualBuilder/generators/generateOverlay.tsx 90% 79.16% 100% 90% 131-140, 177, 195-198, 223-226
src/visualBuilder/listeners/mouseClick.ts 74.72% 80.48% 90.9% 74.72% 104-105, 108-113, 126-154, 180-181, 226, 285-291, 315-320, 329-335, 353-363
src/visualBuilder/listeners/mouseHover.ts 61.56% 50% 62.5% 61.56% 52-59, 76-77, 94-97, 127-137, 143-144, 151-154, 157-159, 165, 179-180, 189-201, 208-210, 212-252, 260-262, 264-266, 274-282, 285-289, 291, 293-295, 310-314, 336-339
Generated in workflow #468 for commit a80d08d by the Vitest Coverage Report Action

@csAyushDubey csAyushDubey merged commit 69328d4 into develop_v3 Jul 16, 2025
9 of 10 checks passed
@csAyushDubey csAyushDubey deleted the VE-6600-Hover-Toolbar-Support branch July 16, 2025 11:17
csAdityaPachauri pushed a commit that referenced this pull request Jul 24, 2025
Fix: HoverToolbar to not render when focussed
csAdityaPachauri pushed a commit that referenced this pull request Jul 24, 2025
Fix: HoverToolbar to not render when focussed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants