Skip to content

Ve 6955 field location data fails to render when toolbar isnt mounted and event listener is missing#462

Merged
SahilCs15 merged 2 commits intodevelop_v3from
VE-6955-field-location-data-fails-to-render-when-toolbar-isnt-mounted-and-event-listener-is-missing
Jul 18, 2025
Merged

Ve 6955 field location data fails to render when toolbar isnt mounted and event listener is missing#462
SahilCs15 merged 2 commits intodevelop_v3from
VE-6955-field-location-data-fails-to-render-when-toolbar-isnt-mounted-and-event-listener-is-missing

Conversation

@SahilCs15
Copy link
Copy Markdown
Contributor

This Pr modifies the way we were fetching field location data

@SahilCs15 SahilCs15 requested a review from a team as a code owner July 17, 2025 09:31
Copy link
Copy Markdown
Contributor

@faraazb faraazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 17, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.78% 9028 / 12576
🔵 Statements 71.78% 9028 / 12576
🔵 Functions 71.68% 324 / 452
🔵 Branches 84.2% 1130 / 1342
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/FieldToolbar.tsx 77.16% 76.59% 37.5% 77.16% 64-112, 134, 173, 206-223, 244-247, 270-279, 308-316, 324-325, 328-329, 381-387, 406-407, 471, 508, 589-596
Generated in workflow #469 for commit d0bb0e5 by the Vitest Coverage Report Action

@SahilCs15
Copy link
Copy Markdown
Contributor Author

1 unit Test is failing merging as the test cases pass on the local

@SahilCs15 SahilCs15 merged commit b43682d into develop_v3 Jul 18, 2025
9 of 13 checks passed
@SahilCs15 SahilCs15 deleted the VE-6955-field-location-data-fails-to-render-when-toolbar-isnt-mounted-and-event-listener-is-missing branch July 18, 2025 13:05
SahilCs15 added a commit that referenced this pull request Jul 24, 2025
sairajchouhan added a commit that referenced this pull request Jul 24, 2025
@faraazb faraazb mentioned this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants