Skip to content

Ve 6955 field location data fails to render when toolbar isnt mounted and event listener is missing #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SahilCs15 merged 2 commits into from
Jul 18, 2025
Merged

Ve 6955 field location data fails to render when toolbar isnt mounted and event listener is missing #462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0300759
fix: modified the way we were handling fieldlocation data fetch
SahilCs15 Jul 17, 2025
d0bb0e5
Merge branch 'develop_v3' into VE-6955-field-location-data-fails-to-r…
SahilCs15 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/visualBuilder/components/FieldToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,17 +392,23 @@ function FieldToolbarComponent(
};
}, []);



useEffect(() => {
const event = visualBuilderPostMessage?.on(
VisualBuilderPostMessageEvents.FIELD_LOCATION_DATA,
(data: { data: any }) => {
setFieldLocationData(data.data.fieldLocationData);
const fetchFieldLocationData = async () => {
try {
const event = await visualBuilderPostMessage?.send(VisualBuilderPostMessageEvents.FIELD_LOCATION_DATA, {
domEditStack: getDOMEditStack(eventDetails.editableElement)
});

setFieldLocationData(event)
} catch (error) {
console.error('Error fetching field location data:', error);
}
);
return () => {
event?.unregister();
};
}, []);

fetchFieldLocationData();
}, [eventDetails.editableElement]);

const multipleFieldToolbarButtonClasses = classNames(
"visual-builder__button visual-builder__button--secondary",
Expand Down
Loading