Skip to content

VE-6918 : warning message improved #475

Merged
csAdityaPachauri merged 3 commits intodevelop_v3from
VE-6918/error-text-main
Jul 30, 2025
Merged

VE-6918 : warning message improved #475
csAdityaPachauri merged 3 commits intodevelop_v3from
VE-6918/error-text-main

Conversation

@csAdityaPachauri
Copy link
Copy Markdown
Contributor

Fix Font Awesome icon styling and vertical alignment issues

Issue Background:

The Font Awesome icon (fas fa-plus) was not rendering correctly because:

  • No Font Awesome dependency in the project's package.json
  • Relied on external dependency - the icon was likely working due to Font Awesome being included as a starter dependency in consuming applications
  • Inconsistent rendering across different environments where Font Awesome wasn't available
Screenshot 2025-07-21 at 5 23 15 PM

@csAdityaPachauri csAdityaPachauri requested a review from a team as a code owner July 30, 2025 11:12
@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.15% 9091 / 12599
🔵 Statements 72.15% 9091 / 12599
🔵 Functions 71.86% 327 / 455
🔵 Branches 84.22% 1132 / 1344
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/visualBuilder.style.ts 100% 100% 100% 100%
src/visualBuilder/components/emptyBlock.tsx 100% 100% 100% 100%
Generated in workflow #493 for commit 7ecfb19 by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@sairajchouhan sairajchouhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@csAdityaPachauri csAdityaPachauri merged commit baea843 into develop_v3 Jul 30, 2025
9 of 10 checks passed
@csAdityaPachauri csAdityaPachauri deleted the VE-6918/error-text-main branch July 30, 2025 12:03
@csAdityaPachauri csAdityaPachauri restored the VE-6918/error-text-main branch August 6, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants