fix: multiple reloads in timeline#479
Merged
contentstackMridul merged 4 commits intodevelop_v3from Aug 5, 2025
Merged
Conversation
KANE-99
reviewed
Aug 5, 2025
| const target: any = event.target; | ||
| const targetHref: string | any = target.href; | ||
| const clickedElement = event.target; | ||
| const anchorElement = clickedElement.closest('a'); |
There was a problem hiding this comment.
@contentstackMridul Have we checked what happens when the clickedElement is itself an anchor?
Contributor
Author
There was a problem hiding this comment.
if the clicked element is itself a anchor element, the .closest method will return the clicked element and it will not traverse the DOM up.
Contributor
Author
There was a problem hiding this comment.
added test for the same
KANE-99
reviewed
Aug 5, 2025
| const anchorElement = clickedElement.closest('a'); | ||
|
|
||
| // Only proceed if the clicked element is either an anchor or a direct/indirect child of an anchor | ||
| if (!anchorElement || !anchorElement.contains(clickedElement)) { |
There was a problem hiding this comment.
what if the anchorElement is same as the clickedElement? @contentstackMridul
Contributor
Author
There was a problem hiding this comment.
if the clicked element is itself a anchor element, the .closest method will return the clicked element and it will not traverse the DOM up.
Contributor
Author
There was a problem hiding this comment.
added test for the same
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: multiple reloads in timeline
Ticket -> https://contentstack.atlassian.net/browse/VE-6673
Test Report ->
This pull request introduces enhancements to the live preview functionality, focusing on improving query parameter handling, adding support for timeline-specific behavior, and refining event listener logic. The most important changes include updates to query parameter management, adjustments to event handling, and integration of timeline-specific checks.
Query Parameter Handling Enhancements:
src/utils/addLivePreviewQueryTags.ts: Added support for thepreview_timestampquery parameter and refined logic for addinglive_preview,content_type_uid, andentry_uidquery parameters.src/utils/index.ts: Improved handling of click events by ensuring query parameters are added only to valid anchor elements and their descendants.Timeline-Specific Behavior:
src/livePreview/eventManager/postMessageEvent.hooks.ts: IntegratedisOpeningInTimeline()check to conditionally add query parameters when initializing live preview post messages.Event Listener Refinements:
src/livePreview/__test__/live-preview.test.ts: ChangedsendInitEventdeclaration fromlettoconstfor clarity and consistency.src/livePreview/eventManager/postMessageEvent.hooks.ts: ImportedisOpeningInTimelineutility for timeline-specific checks.