feat(VE-7062-dev): disable editing based on workflow stage rules#489
Merged
faraazb merged 12 commits intodevelop_v3from Aug 13, 2025
Merged
feat(VE-7062-dev): disable editing based on workflow stage rules#489faraazb merged 12 commits intodevelop_v3from
faraazb merged 12 commits intodevelop_v3from
Conversation
Fetch workflow stage details for the entry from parent and disable editing based on the received data
faraazb
changed the title
…7062-disable-entry-edit-workflow-stage
…7062-disable-entry-edit-workflow-stage
faraazb
changed the title
csAyushDubey
approved these changes
Aug 11, 2025
Contributor
csAyushDubey
left a comment
csAyushDubey
left a comment
There was a problem hiding this comment.
Changes look good, just a few suggestions
| }); | ||
| } else if ( | ||
| eventName === | ||
| VisualBuilderPostMessageEvents.GET_WORKFLOW_STAGE_DETAILS |
There was a problem hiding this comment.
@faraazb - Why not use switch instead of so many else if's?
Contributor
Author
There was a problem hiding this comment.
I can. Will make the change. Will do it across all the 3 files.
| VisualBuilderPostMessageEvents.GET_WORKFLOW_STAGE_DETAILS | ||
| ) { | ||
| return Promise.resolve({ | ||
| stage: { name: "Example Stage" }, |
There was a problem hiding this comment.
Can we move "Example Stage" to a constant since its used at multiple places?
| VisualBuilderPostMessageEvents.GET_WORKFLOW_STAGE_DETAILS | ||
| ) { | ||
| return Promise.resolve({ | ||
| stage: { name: "Example Stage" }, |
There was a problem hiding this comment.
Same comment on applicable cases where string name is "Example Stage"
| entryAclPromise, | ||
| entryWorkflowStageDetailsPromise, | ||
| ]); | ||
| if (results[0].status === "rejected") { |
There was a problem hiding this comment.
use constants for rejected and fulfilled.
Contributor
Author
There was a problem hiding this comment.
"rejected" or "fulfilled" are built in values for Promise status. I think this is fine.
faraazb
force-pushed
the
dev-VE-7062-disable-entry-edit-workflow-stage
branch
from
a2d04f6 to
b26c4ac
Compare
…7062-disable-entry-edit-workflow-stage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes
isFieldDisabled.tssimilar toQuickFormInfoBannerin Visual BuilderisFieldDisabled.tsutility