Skip to content

fix(VE-7148): fixed the issue regarding pointer moving to the start while focusing and unfoucsing on a field #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SahilCs15 wants to merge 1 commit into from
Closed

fix(VE-7148): fixed the issue regarding pointer moving to the start while focusing and unfoucsing on a field #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/livePreview/eventManager/postMessageEvent.hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Config, { setConfigFromParams } from "../../configManager/configManager";
import { ILivePreviewWindowType } from "../../types/types";
import { addParamsToUrl, isOpeningInTimeline } from "../../utils";
import { VisualBuilder } from "../../visualBuilder";
import livePreviewPostMessage from "./livePreviewEventManager";
import { LIVE_PREVIEW_POST_MESSAGE_EVENTS } from "./livePreviewEventManager.constant";
import {
Expand All @@ -27,6 +28,7 @@ export function useHistoryPostMessageEvent(): void {
break;
}
case "reload": {
if(VisualBuilder.VisualBuilderGlobalState.value.isEditing) return;
window.history.go();
break;
}
Expand All @@ -46,6 +48,7 @@ export function useOnEntryUpdatePostMessageEvent(): void {
livePreviewPostMessage?.on<OnChangeLivePreviewPostMessageEventData>(
LIVE_PREVIEW_POST_MESSAGE_EVENTS.ON_CHANGE,
(event) => {
if(VisualBuilder.VisualBuilderGlobalState.value.isEditing) return;
setConfigFromParams({
live_preview: event.data.hash,
});
Expand Down
1 change: 1 addition & 0 deletions src/visualBuilder/generators/generateOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ interface HideOverlayParams

export function hideOverlay(params: HideOverlayParams): void {
VisualBuilder.VisualBuilderGlobalState.value.isFocussed = false;
VisualBuilder.VisualBuilderGlobalState.value.isEditing = false;
const focusElementObserver =
VisualBuilder.VisualBuilderGlobalState.value.focusElementObserver;
if (focusElementObserver) {
Expand Down
3 changes: 3 additions & 0 deletions src/visualBuilder/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ interface VisualBuilderGlobalStateImpl {
focusElementObserver: MutationObserver | null;
referenceParentMap: Record<string, string>;
isFocussed: boolean;
isEditing: boolean;
}

let threadsPayload: IThreadDTO[] = [];
Expand All @@ -92,6 +93,7 @@ export class VisualBuilder {
focusElementObserver: null,
referenceParentMap: {},
isFocussed: false,
isEditing: false,
});

private handlePositionChange(editableElement: HTMLElement) {
Expand Down Expand Up @@ -444,6 +446,7 @@ export class VisualBuilder {
focusElementObserver: null,
referenceParentMap: {},
isFocussed: false,
isEditing: false,
};

// Remove DOM elements
Expand Down
2 changes: 2 additions & 0 deletions src/visualBuilder/utils/enableInlineEditing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ export function enableInlineEditing({
VisualBuilder.VisualBuilderGlobalState.value.focusFieldValue =
actualEditableField?.innerText;

VisualBuilder.VisualBuilderGlobalState.value.isEditing = true;

const elementComputedDisplay =
window.getComputedStyle(actualEditableField).display;

Expand Down
Loading