Live preview new tab ssr issue#502
Merged
contentstackMridul merged 5 commits into18th-sept-2025-releasefrom Sep 16, 2025
Merged
Live preview new tab ssr issue#502contentstackMridul merged 5 commits into18th-sept-2025-releasefrom
contentstackMridul merged 5 commits into18th-sept-2025-releasefrom
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
KANE-99
reviewed
Sep 16, 2025
| it("should reload window when ssr is true and no event_type", () => { | ||
| // Set URL to include live_preview parameter so reload path is taken | ||
| mockWindow.location.href = "https://example.com?live_preview=old-hash"; | ||
| it("should reload window when ssr is true and no event_type and all params present", () => { |
There was a problem hiding this comment.
@contentstackMridul Just want to know that whether this test was newly added by us? or the live preview used to work like this?
Contributor
Author
There was a problem hiding this comment.
@KANE-99, earlier the test was checking for the live preview hash only, but ideally we should check for all the params in the SSR case
KANE-99
reviewed
Sep 16, 2025
|
|
||
| if (contentTypeUid && entryUid) { | ||
| // TODO: we should not use this function. Instead we should have sideEffect run automatically when we set the config. | ||
| console.log("setConfigFromParams", contentTypeUid, entryUid); |
KANE-99
reviewed
Sep 16, 2025
| if (contentTypeUid && entryUid) { | ||
| // TODO: we should not use this function. Instead we should have sideEffect run automatically when we set the config. | ||
| console.log("setConfigFromParams", contentTypeUid, entryUid); | ||
| // setConfigFromParams(`?content_type_uid=${contentTypeUid}&entry_uid=${entryUid}`); |
KANE-99
reviewed
Sep 16, 2025
| @@ -1 +1,11 @@ | |||
| * @contentstack/security-admin | |||
| * @contentstack/ghost-pr-reviewers | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live preview new tab ssr issue