-
Notifications
You must be signed in to change notification settings - Fork 1
Live preview new tab ssr issue #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
52f91a4
1b89e20
b78db51
f3c6abc
e65d15c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,11 @@ | ||
| * @contentstack/security-admin | ||
| * @contentstack/ghost-pr-reviewers | ||
|
|
||
| .github/workflows/sca-scan.yml @contentstack/security-admin | ||
|
|
||
| .github/workflows/codeql-anaylsis.yml @contentstack/security-admin | ||
|
|
||
| **/.snyk @contentstack/security-admin | ||
|
|
||
| .github/workflows/policy-scan.yml @contentstack/security-admin | ||
|
|
||
| .github/workflows/issues-jira.yml @contentstack/security-admin | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -159,9 +159,9 @@ describe("postMessageEvent.hooks", () => { | |
| (Config.get as any).mockReturnValue(mockConfig); | ||
| }); | ||
|
|
||
| it("should reload window when ssr is true and no event_type", () => { | ||
| // Set URL to include live_preview parameter so reload path is taken | ||
| mockWindow.location.href = "https://example.com?live_preview=old-hash"; | ||
| it("should reload window when ssr is true and no event_type and all params present", () => { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @contentstackMridul Just want to know that whether this test was newly added by us? or the live preview used to work like this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @KANE-99, earlier the test was checking for the live preview hash only, but ideally we should check for all the params in the SSR case |
||
| // Set URL to include all required params so reload path is taken | ||
| mockWindow.location.href = "https://example.com?live_preview=old-hash&content_type_uid=blog&entry_uid=entry-123"; | ||
|
|
||
| const eventData: OnChangeLivePreviewPostMessageEventData = { | ||
| hash: "test-hash", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are this changes from main branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes