Skip to content

Revert "VB-277 :fix(VB-277/truncate-handlling):function added to remove and store styles" #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csAdityaPachauri merged 1 commit into from
Sep 30, 2025
Merged

Revert "VB-277 :fix(VB-277/truncate-handlling):function added to remove and store styles" #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/visualBuilder/generators/generateOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ import { FieldDataType } from "../utils/types/index.types";
import { getFieldType } from "../utils/getFieldType";
import { getMultilinePlaintext } from "../utils/getMultilinePlaintext";
import { showAllHiddenHighlightedCommentIcons } from "./generateHighlightedComment";
import {
restoreTruncateStyles,
hasStoredLineClampStyles,
} from "../utils/truncateHandler";

/**
* Adds a focus overlay to the target element.
Expand Down Expand Up @@ -228,18 +224,6 @@ export function hideOverlay(params: HideOverlayParams): void {
VisualBuilder.VisualBuilderGlobalState.value.focusElementObserver =
null;
}

// Restore truncate styles for the previously selected element before hiding overlay
const previousSelectedElement =
VisualBuilder.VisualBuilderGlobalState.value
.previousSelectedEditableDOM;
if (
previousSelectedElement &&
hasStoredLineClampStyles(previousSelectedElement)
) {
restoreTruncateStyles(previousSelectedElement);
}

hideFocusOverlay({
visualBuilderContainer: params.visualBuilderContainer,
visualBuilderOverlayWrapper: params.visualBuilderOverlayWrapper,
Expand Down
17 changes: 0 additions & 17 deletions src/visualBuilder/listeners/mouseClick.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ import { fixSvgXPath } from "../utils/collabUtils";
import { v4 as uuidV4 } from "uuid";
import { CslpData } from "../../cslp/types/cslp.types";
import { fetchEntryPermissionsAndStageDetails } from "../utils/fetchEntryPermissionsAndStageDetails";
import {
removeTruncateStyles,
restoreTruncateStyles,
hasStoredLineClampStyles,
} from "../utils/truncateHandler";

export type HandleBuilderInteractionParams = Omit<
EventListenerHandlerParams,
Expand Down Expand Up @@ -248,14 +243,6 @@ function cleanResidualsIfNeeded(
previousSelectedElement !== editableElement) ||
params.reEvaluate
) {
// Restore truncate styles for the previously selected element
if (
previousSelectedElement &&
hasStoredLineClampStyles(previousSelectedElement)
) {
restoreTruncateStyles(previousSelectedElement);
}

cleanIndividualFieldResidual({
overlayWrapper: params.overlayWrapper!,
visualBuilderContainer: params.visualBuilderContainer,
Expand Down Expand Up @@ -290,10 +277,6 @@ function addOverlayAndToolbar(
isVariant: boolean
) {
VisualBuilder.VisualBuilderGlobalState.value.isFocussed = true;

// Remove truncate styles from the focused element
removeTruncateStyles(editableElement);

addOverlay({
overlayWrapper: params.overlayWrapper,
resizeObserver: params.resizeObserver,
Expand Down
237 changes: 0 additions & 237 deletions src/visualBuilder/utils/__test__/clearStyles.test.ts
View file
Open in desktop

This file was deleted.

Loading
Loading