Skip to content

[Feat/VB-499] Added resolved variants' permission communication and field disablement#517

Merged
csAyushDubey merged 7 commits intodevelop_v4from
feature/VB-499-resolved-variant-perms
Oct 31, 2025
Merged

[Feat/VB-499] Added resolved variants' permission communication and field disablement#517
csAyushDubey merged 7 commits intodevelop_v4from
feature/VB-499-resolved-variant-perms

Conversation

@csAyushDubey
Copy link
Copy Markdown
Contributor

No description provided.

@csAyushDubey csAyushDubey requested a review from a team as a code owner October 28, 2025 05:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 28, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.66% 9416 / 12958
🔵 Statements 72.66% 9416 / 12958
🔵 Functions 71.73% 335 / 467
🔵 Branches 84.28% 1201 / 1425
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/FieldToolbar.tsx 77.35% 75% 37.5% 77.35% 64-112, 136, 176, 211-228, 249-252, 275-284, 313-321, 329-330, 333-334, 386-392, 409-410, 474, 511, 592-599
src/visualBuilder/components/fieldLabelWrapper.tsx 81.3% 72.58% 80% 81.3% 46-48, 56-58, 140-151, 154-158, 221-222, 226-231, 235, 300-302, 308-326, 331-343
src/visualBuilder/eventManager/useVariantsPostMessageEvent.ts 98.23% 90% 100% 98.23% 48-49
src/visualBuilder/generators/generateToolbar.tsx 90.13% 86.66% 83.33% 90.13% 28-29, 92-97, 145-149, 192-193
src/visualBuilder/listeners/mouseClick.ts 76.1% 70% 90.9% 76.1% 88, 98-104, 109-110, 113-118, 131-159, 171-172, 185-186, 231, 290-296, 361-371
src/visualBuilder/listeners/mouseHover.ts 63.77% 43.24% 52.38% 63.77% 49-56, 73-74, 125-135, 141-142, 149-152, 155-157, 163, 177-178, 189-205, 212-214, 216-259, 267-269, 271-273, 281-289, 292-295, 297-299, 314-318, 382-383
src/visualBuilder/utils/fetchEntryPermissionsAndStageDetails.ts 75.8% 14.28% 100% 75.8% 42-46, 48-52, 54-58
src/visualBuilder/utils/getResolvedVariantPermissions.ts 100% 100% 100% 100%
src/visualBuilder/utils/handleIndividualFields.ts 100% 100% 100% 100%
src/visualBuilder/utils/isFieldDisabled.ts 98.34% 95.83% 100% 98.34% 121-122
src/visualBuilder/utils/updateFocussedState.ts 56.74% 60.71% 100% 56.74% 45, 57-59, 61-63, 65, 205-208, 210-241, 328-332, 335-352, 355-365, 368-385, 392-437, 444-466, 472-474
src/visualBuilder/utils/types/postMessage.types.ts 100% 100% 100% 100%
Generated in workflow #587 for commit 0dc07d6 by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe few comment from this is not resolved yet

@hiteshshetty-dev
Copy link
Copy Markdown
Contributor

Test cases are also failing

@csAyushDubey
Copy link
Copy Markdown
Contributor Author

Test cases are also failing

Fixed the tests, please let me know if there's anything missing.

Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@csAyushDubey csAyushDubey merged commit 88394b6 into develop_v4 Oct 31, 2025
9 of 10 checks passed
@csAyushDubey csAyushDubey deleted the feature/VB-499-resolved-variant-perms branch October 31, 2025 08:27
@hiteshshetty-dev hiteshshetty-dev restored the feature/VB-499-resolved-variant-perms branch November 27, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants