Skip to content

fix: update font-family to include sans-serif fallback in collab and visual builder styles#519

Merged
hiteshshetty-dev merged 3 commits intodevelop_v4from
VB-633
Nov 5, 2025
Merged

fix: update font-family to include sans-serif fallback in collab and visual builder styles#519
hiteshshetty-dev merged 3 commits intodevelop_v4from
VB-633

Conversation

@hiteshshetty-dev
Copy link
Copy Markdown
Contributor

Title

Few of the elements in LP SDK have strict font-family: Inter without any fallback for font. This PR adds sans-serif as fallback font.

Before
Screenshot 2025-11-05 at 12 09 42 PM

After:
Screenshot 2025-11-05 at 12 17 15 PM

@hiteshshetty-dev hiteshshetty-dev requested a review from a team as a code owner November 5, 2025 06:47
Copy link
Copy Markdown
Contributor

@karancs06 karancs06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.59% 9407 / 12958
🔵 Statements 72.59% 9407 / 12958
🔵 Functions 71.73% 335 / 467
🔵 Branches 83.9% 1183 / 1410
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/collab.style.ts 100% 100% 100% 100%
src/visualBuilder/visualBuilder.style.ts 100% 100% 100% 100%
Generated in workflow #595 for commit 86f579a by the Vitest Coverage Report Action

@prathamesh-sawant-cs
Copy link
Copy Markdown

prathamesh-sawant-cs commented Nov 5, 2025

Test case failures.

Changes look good, is there a way we can test that the change in CSS works using a test case?

@hiteshshetty-dev hiteshshetty-dev merged commit 1b594a6 into develop_v4 Nov 5, 2025
10 checks passed
@hiteshshetty-dev hiteshshetty-dev deleted the VB-633 branch November 5, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants