Update preact and preact/signals packages to fix global sCU issue#520
Merged
hiteshshetty-dev merged 2 commits intodevelop_v4from Nov 5, 2025
Merged
Update preact and preact/signals packages to fix global sCU issue#520hiteshshetty-dev merged 2 commits intodevelop_v4from
hiteshshetty-dev merged 2 commits intodevelop_v4from
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
| : "" | ||
| )} | ||
| ref={(el) => (itemRefs.current[index] = el)} | ||
| ref={(el) => { |
There was a problem hiding this comment.
We should revert this since there is no change except formatting. Rest looks good to me.
Contributor
Author
There was a problem hiding this comment.
We had to fix this, here we have incorrect ref configured for component which throws error while build.
prathamesh-sawant-cs
approved these changes
Nov 5, 2025
Contributor
Author
We are currently working on rewrite of these case. It has been failing on CI for quite of time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With preact/signals
1.3.2the global shouldComponentUpdate lifecycle hooks are not working with preact. It was recently fixed with latest preact version. We have updated both the packages.