fix: handle empty data-cslp attributes in getEntryIdentifiersInCurrentPage function#528
Merged
hiteshshetty-dev merged 3 commits intodevelop_v4from Dec 1, 2025
Merged
fix: handle empty data-cslp attributes in getEntryIdentifiersInCurrentPage function#528hiteshshetty-dev merged 3 commits intodevelop_v4from
hiteshshetty-dev merged 3 commits intodevelop_v4from
Conversation
csAyushDubey
suggested changes
Nov 25, 2025
faraazb
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Publish modal doesn’t load in Visual Builder
Description
If the website contains any DOM node with an empty CSLP element, the Page Status, Sidebar Rails, or Publish Modal may fail to load. This occurs because our logic for extracting all elements on the website crashes in such cases, causing the postMessage flow to break and preventing these screens from loading.
We are addressing this by adding proper handling for empty CSLP elements to avoid extraction failures.
Before:
Screen.Recording.2025-11-25.at.5.36.43.PM.mov
After:
Screen.Recording.2025-11-25.at.5.35.06.PM.mov