Skip to content

fix: handle empty data-cslp attributes in getEntryIdentifiersInCurrentPage function #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiteshshetty-dev merged 3 commits into from
Dec 1, 2025
Merged

fix: handle empty data-cslp attributes in getEntryIdentifiersInCurrentPage function #528

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34b7e42
fix: handle empty data-cslp attributes in getEntryIdentifiersInCurren…
hitesh-shetty-cstk Nov 25, 2025
b1da67e
test: add additional header element to getEntryIdentifiersInCurrentPa…
hitesh-shetty-cstk Nov 26, 2025
ba91cb0
fix: handle invalid data-cslp attributes across multiple components t…
hitesh-shetty-cstk Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/visualBuilder/utils/__test__/getEntryIdentifiersInCurrentPage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,16 @@ describe("getEntryIdentifiersInCurrentPage", () => {
expect(entriesInCurrentPage.length).toBe(0);
expect(entriesInCurrentPage).toEqual([]);
});

test("should filter out elements with empty data-cslp attribute and not break", () => {
document.body.innerHTML = `
<div>
<h1 data-cslp="">Empty CSLP</h1>
<h1 data-cslp="page.bltf5bb5f8fb088a332.en-us.page_components.0.hero_banner.banner_title">Valid CSLP</h1>
Comment thread
csAyushDubey marked this conversation as resolved.
</div>
`;
const { entriesInCurrentPage } = getEntryIdentifiersInCurrentPage();
expect(entriesInCurrentPage.length).toBe(1);
expect(entriesInCurrentPage[0].entryUid).toBe('bltf5bb5f8fb088a332');
});
});
6 changes: 3 additions & 3 deletions src/visualBuilder/utils/getEntryIdentifiersInCurrentPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ export function getEntryIdentifiersInCurrentPage(): EntryIdentifiers {
);
const uniqueEntriesMap = new Map<string, { entryUid: string, contentTypeUid: string, locale: string}>();
elementsWithCslp.forEach((element) => {
const cslpData = extractDetailsFromCslp(
element.getAttribute("data-cslp") as string
);
const cslpValue = element.getAttribute("data-cslp");
if (!cslpValue) return;
const cslpData = extractDetailsFromCslp(cslpValue);
Comment thread
hiteshshetty-dev marked this conversation as resolved.
uniqueEntriesMap.set(cslpData.entry_uid,
{
entryUid: cslpData.entry_uid,
Expand Down
Loading