Skip to content

DRFT-207: added support for field locking through canvas#535

Merged
SahilCs15 merged 5 commits intoce-auto-draftfrom
DRFT-207
Dec 22, 2025
Merged

DRFT-207: added support for field locking through canvas#535
SahilCs15 merged 5 commits intoce-auto-draftfrom
DRFT-207

Conversation

@SahilCs15
Copy link
Copy Markdown
Contributor

No description provided.

@SahilCs15 SahilCs15 requested a review from a team as a code owner December 17, 2025 06:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.52% 8198 / 11461
🔵 Statements 71.52% 8198 / 11461
🔵 Functions 74.36% 322 / 433
🔵 Branches 84.93% 1212 / 1427
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/visualBuilder.style.ts 100% 100% 100% 100%
src/visualBuilder/components/fieldLabelWrapper.tsx 76.9% 81.15% 72.72% 76.9% 48-50, 58-60, 145-158, 184-213, 234, 238-254, 282-283, 287-292, 378-396, 444-454
src/visualBuilder/components/icons/index.tsx 84.25% 95% 83.33% 84.25% 210-234, 348-360, 363-380
src/visualBuilder/generators/generateHoverOutline.tsx 68.42% 25% 100% 68.42% 27-35, 37-42, 51-53
src/visualBuilder/generators/generateOverlay.tsx 89.74% 76.66% 100% 89.74% 139-148, 206-209, 223-224, 228-229, 237-239, 266-269
src/visualBuilder/generators/generateToolbar.tsx 90.79% 87.5% 83.33% 90.79% 28-29, 93-98, 151-155, 198-199
src/visualBuilder/listeners/index.ts 97.64% 100% 100% 97.64% 63-64
src/visualBuilder/listeners/mouseClick.ts 75.44% 66.66% 91.66% 75.44% 93, 103-109, 114-115, 118-123, 136-164, 176-177, 194-200, 212-213, 258, 317-323, 367-373, 391-401, 427-429
src/visualBuilder/listeners/mouseHover.ts 59.72% 34.09% 48.14% 59.72% 56-63, 80-81, 98-105, 126, 152-162, 168-169, 176-179, 182-184, 190, 205-206, 222-249, 256-258, 261-263, 278, 289-332, 340-342, 344-346, 354-362, 365-368, 370-372, 387-391, 436-437, 457-458, 500-503, 532-533, 535-537, 541-543, 546-600
Generated in workflow #718 for commit 4d0607c by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@sairajchouhan sairajchouhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, also one more thing, we have few utility methods like checkFieldLockStatus, checkAndApplyFieldLockStatus, removeAllLockedFieldStyling lying across files and reused in some other files, lets create a utils file for these draft related functions and put all of them there

Comment thread src/visualBuilder/listeners/mouseHover.ts
Comment thread src/visualBuilder/listeners/mouseHover.ts Outdated
Comment thread src/visualBuilder/utils/types/postMessage.types.ts Outdated
Copy link
Copy Markdown
Contributor

@sairajchouhan sairajchouhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SahilCs15 SahilCs15 merged commit 3f1697f into ce-auto-draft Dec 22, 2025
10 checks passed
@SahilCs15 SahilCs15 deleted the DRFT-207 branch December 22, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants