Skip to content

fix(VB-1330): isFieldDisabled exactOptionalPropertyTypes for DTS build#573

Merged
hiteshshetty-dev merged 1 commit intodevelop_v4from
VB-1330
Mar 27, 2026
Merged

fix(VB-1330): isFieldDisabled exactOptionalPropertyTypes for DTS build#573
hiteshshetty-dev merged 1 commit intodevelop_v4from
VB-1330

Conversation

@hiteshshetty-dev
Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev commented Mar 27, 2026

Summary

Fixes tsup DTS build failures under exactOptionalPropertyTypes in isFieldDisabled.ts.

Changes

  • Build getDisableReason params without assigning undefined to optional properties (stageName, entryWorkflowStageDetails, entryPermissions).
  • Return FieldDisableState with workflowRequestUi omitted when unset instead of workflowRequestUi: undefined.

Verification

  • npm run build succeeds (DTS emit).

Ticket

VB-1330

Made with Cursor

@hiteshshetty-dev hiteshshetty-dev requested review from a team as code owners March 27, 2026 12:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

kirtesh-cstk
kirtesh-cstk approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown

@kirtesh-cstk kirtesh-cstk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.06% 8243 / 11438
🔵 Statements 72.06% 8243 / 11438
🔵 Functions 74.82% 327 / 437
🔵 Branches 85.87% 1258 / 1465
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/utils/isFieldDisabled.ts 97.79% 95.83% 100% 97.79% 106-107, 160-161
Generated in workflow #772 for commit f414e81 by the Vitest Coverage Report Action

@hiteshshetty-dev hiteshshetty-dev merged commit 7b2c724 into develop_v4 Mar 27, 2026
9 checks passed
@hiteshshetty-dev hiteshshetty-dev deleted the VB-1330 branch March 27, 2026 12:55
@karancs06 karancs06 mentioned this pull request Apr 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirtesh-cstk kirtesh-cstk kirtesh-cstk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiteshshetty-dev @kirtesh-cstk @hitesh-shetty-cstk