Go

[1Patrik1]

Description

[ What changed? Feel free to be brief. ]

AI Code Review

• Team members only: AI review runs automatically when PR is opened or marked ready for review
• Team members can also trigger a review by commenting @continue-review

Checklist

• [] I've read the contributing guide
• [] The relevant docs, if any, have been updated or created
• [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

---

Summary by cubic

Set up CI for linting, testing, and TypeScript type checks on pushes and PRs to main. Added a root ESLint config and a small README comment.

• New Features
  • Add CI workflows: lint (eslint + prettier), tests (Node 20; runs in core and binary; uploads coverage), and TypeScript type-check.
  • Add root .eslintrc.json extending .eslintrc.shared.json.
  • Add a bot instruction comment to the README.

^{Written for commit c04a2f7. Summary will update on new commits.}

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[1Patrik1]

Vše schvaluji

[cubic-dev-ai]

5 issues found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/lint.yml">

<violation number="1" location=".github/workflows/lint.yml:13">
P2: Lint workflow does not configure a pinned Node.js version, making CI behavior dependent on changing runner defaults.</violation>

<violation number="2" location=".github/workflows/lint.yml:20">
P2: Use `npm ci` instead of `npm install` in CI to ensure deterministic lint dependencies and avoid dependency drift.</violation>
</file>

<file name=".github/workflows/test.yml">

<violation number="1" location=".github/workflows/test.yml:28">
P2: CI workflow uses `npm install` instead of `npm ci`, reducing install reproducibility and consistency with existing CI jobs.</violation>

<violation number="2" location=".github/workflows/test.yml:32">
P1: Workflow is configured to ignore test failures, allowing CI to pass even when tests fail.</violation>
</file>

<file name=".github/workflows/type-check.yml">

<violation number="1" location=".github/workflows/type-check.yml:1">
P1: Workflow YAML was committed with literal `\n` escapes on one line, which can prevent GitHub Actions from parsing and running the type-check job.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

P1: Workflow YAML was committed with literal \n escapes on one line, which can prevent GitHub Actions from parsing and running the type-check job.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/type-check.yml, line 1:

<comment>Workflow YAML was committed with literal `\n` escapes on one line, which can prevent GitHub Actions from parsing and running the type-check job.</comment>

<file context>
@@ -0,0 +1 @@
+name: TypeScript Type Checking\n\non:\n  push:\n    branches:\n      - main\n  pull_request:\n    branches:\n      - main\n\njobs:\n  type-check:\n    runs-on: ubuntu-latest\n    steps:\n      - name: Checkout repository\n        uses: actions/checkout@v2\n        \n      - name: Setup Node.js\n        uses: actions/setup-node@v2\n        with:\n          node-version: '14'\n        \n      - name: Install dependencies\n        run: |\n          npm install\n        \n      - name: Type Check\n        run: |\n          npm run type-check\n        env:\n          CI: true\n
\ No newline at end of file
</file context>

[cubic-dev-ai]

P2: Use npm ci instead of npm install in CI to ensure deterministic lint dependencies and avoid dependency drift.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/lint.yml, line 20:

<comment>Use `npm ci` instead of `npm install` in CI to ensure deterministic lint dependencies and avoid dependency drift.</comment>

<file context>
@@ -0,0 +1,28 @@
+
+      - name: Install dependencies
+        run: |
+          npm install
+
+      - name: Run ESLint
</file context>

[cubic-dev-ai]

P2: Lint workflow does not configure a pinned Node.js version, making CI behavior dependent on changing runner defaults.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/lint.yml, line 13:

<comment>Lint workflow does not configure a pinned Node.js version, making CI behavior dependent on changing runner defaults.</comment>

<file context>
@@ -0,0 +1,28 @@
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
</file context>

[cubic-dev-ai]

P2: CI workflow uses npm install instead of npm ci, reducing install reproducibility and consistency with existing CI jobs.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test.yml, line 28:

<comment>CI workflow uses `npm install` instead of `npm ci`, reducing install reproducibility and consistency with existing CI jobs.</comment>

<file context>
@@ -0,0 +1,40 @@
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm install
+
+      - name: Run tests for core
</file context>

Suggested change

	run: npm install
	run: npm ci