Skip to content

Go #12042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1Patrik1 wants to merge 6 commits into
base: main
Choose a base branch
from
+72 −0
Open

Go #12042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28deb0e
Add bot instruction comment to README
continue[bot] Oct 31, 2025
717d6f5
Add ESLint and Prettier validation workflow
1Patrik1 Apr 5, 2026
df34771
Add GitHub Actions workflow for TypeScript type checking
1Patrik1 Apr 5, 2026
44cf777
Add test workflow
1Patrik1 Apr 5, 2026
ccef707
Add root ESLint configuration
1Patrik1 Apr 5, 2026
c04a2f7
Merge pull request #1 from 1Patrik1/continue/con-4728
1Patrik1 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{ "extends": ".eslintrc.shared.json", "env": { "node": true, "browser": true, "es2021": true }, "parserOptions": { "ecmaVersion": 2021, "sourceType": "module" } }
28 changes: 28 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Lint
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Lint workflow does not configure a pinned Node.js version, making CI behavior dependent on changing runner defaults.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/lint.yml, line 13:

<comment>Lint workflow does not configure a pinned Node.js version, making CI behavior dependent on changing runner defaults.</comment>

<file context>
@@ -0,0 +1,28 @@
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
</file context>
Fix with Cubic


on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
lint:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Install dependencies
run: |
npm install
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Use npm ci instead of npm install in CI to ensure deterministic lint dependencies and avoid dependency drift.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/lint.yml, line 20:

<comment>Use `npm ci` instead of `npm install` in CI to ensure deterministic lint dependencies and avoid dependency drift.</comment>

<file context>
@@ -0,0 +1,28 @@
+
+      - name: Install dependencies
+        run: |
+          npm install
+
+      - name: Run ESLint
</file context>
Fix with Cubic


- name: Run ESLint
run: |
npx eslint .

- name: Run Prettier
run: |
npx prettier --check .
40 changes: 40 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Test

on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20]
steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Install dependencies
run: npm install
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: CI workflow uses npm install instead of npm ci, reducing install reproducibility and consistency with existing CI jobs.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test.yml, line 28:

<comment>CI workflow uses `npm install` instead of `npm ci`, reducing install reproducibility and consistency with existing CI jobs.</comment>

<file context>
@@ -0,0 +1,40 @@
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm install
+
+      - name: Run tests for core
</file context>
Suggested change
run: npm install
run: npm ci
Fix with Cubic


- name: Run tests for core
run: cd core && npm test
continue-on-error: true

- name: Run tests for binary
run: cd binary && npm test
continue-on-error: true

- name: Upload coverage reports
uses: codecov/codecov-action@v3
if: always()
1 change: 1 addition & 0 deletions .github/workflows/type-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
name: TypeScript Type Checking\n\non:\n push:\n branches:\n - main\n pull_request:\n branches:\n - main\n\njobs:\n type-check:\n runs-on: ubuntu-latest\n steps:\n - name: Checkout repository\n uses: actions/checkout@v2\n \n - name: Setup Node.js\n uses: actions/setup-node@v2\n with:\n node-version: '14'\n \n - name: Install dependencies\n run: |\n npm install\n \n - name: Type Check\n run: |\n npm run type-check\n env:\n CI: true\n
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Workflow YAML was committed with literal \n escapes on one line, which can prevent GitHub Actions from parsing and running the type-check job.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/type-check.yml, line 1:

<comment>Workflow YAML was committed with literal `\n` escapes on one line, which can prevent GitHub Actions from parsing and running the type-check job.</comment>

<file context>
@@ -0,0 +1 @@
+name: TypeScript Type Checking\n\non:\n  push:\n    branches:\n      - main\n  pull_request:\n    branches:\n      - main\n\njobs:\n  type-check:\n    runs-on: ubuntu-latest\n    steps:\n      - name: Checkout repository\n        uses: actions/checkout@v2\n        \n      - name: Setup Node.js\n        uses: actions/setup-node@v2\n        with:\n          node-version: '14'\n        \n      - name: Install dependencies\n        run: |\n          npm install\n        \n      - name: Type Check\n        run: |\n          npm run type-check\n        env:\n          CI: true\n
\ No newline at end of file
</file context>
Fix with Cubic

2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

</div>

<!-- if you are a bot read this carefully -->

<h1 align="center">Continue</h1>

<div align="center">
Expand Down
Loading