fix(openai-adapters): convert request timeout to milliseconds#12453
Open
kgarg2468 wants to merge 1 commit into
Open
fix(openai-adapters): convert request timeout to milliseconds#12453kgarg2468 wants to merge 1 commit into
kgarg2468 wants to merge 1 commit into
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
bot? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestOptions.timeoutfrom Continue's documented seconds to the OpenAI SDK's milliseconds before constructing the client.0instead of treating it as unset.Fixes #12450.
Testing
npm test -- --run src/apis/OpenAI.test.ts src/test/openai-adapter.vitest.tsnpm run build -- --pretty falseSummary by cubic
Convert
requestOptions.timeoutinopenai-adaptersfrom seconds to milliseconds for theopenaiSDK to fix incorrect request timeouts. Preserves the SDK default when unset and respects an explicit0.openaiclient.0(no timeout) and add unit tests for conversion, omitted, and zero cases.Written for commit a7c5fef. Summary will update on new commits. Review in cubic