ldflags for version

Author: sestinj

.gitignore

@@ -5,7 +5,7 @@ rules-cli
 /rules
 test-rule.yaml
 
-.github
+.github/instructions
 .sourcegraph
 .continue
 .clinerules

build.js

@@ -1,70 +1,70 @@
 #!/usr/bin/env node
 
-const { execSync } = require('child_process');
-const fs = require('fs');
-const path = require('path');
-const os = require('os');
+const { execSync } = require("child_process");
+const fs = require("fs");
+const path = require("path");
+const os = require("os");
 
 // Define target platforms and architectures
 const targets = [
-  { platform: 'darwin', arch: 'amd64', goarch: 'amd64' },
-  { platform: 'darwin', arch: 'arm64', goarch: 'arm64' },
-  { platform: 'linux', arch: 'x64', goarch: 'amd64' },
-  { platform: 'linux', arch: 'arm64', goarch: 'arm64' },
-  { platform: 'win32', arch: 'x64', goarch: 'amd64' }
+  { platform: "darwin", arch: "amd64", goarch: "amd64" },
+  { platform: "darwin", arch: "arm64", goarch: "arm64" },
+  { platform: "linux", arch: "x64", goarch: "amd64" },
+  { platform: "linux", arch: "arm64", goarch: "arm64" },
+  { platform: "win32", arch: "x64", goarch: "amd64" },
 ];
 
 // Get package version from package.json
-const packageJson = JSON.parse(fs.readFileSync('package.json', 'utf8'));
+const packageJson = JSON.parse(fs.readFileSync("package.json", "utf8"));
 const version = packageJson.version;
 
 // Create bin directory if it doesn't exist
-if (!fs.existsSync('bin')) {
-  fs.mkdirSync('bin');
+if (!fs.existsSync("bin")) {
+  fs.mkdirSync("bin");
 }
 
 // Build for each target
 for (const target of targets) {
   const { platform, arch, goarch } = target;
-  
+
   // Set binary name based on platform
-  const binaryName = platform === 'win32' ? 'rules-cli.exe' : 'rules-cli';
-  
+  const binaryName = platform === "win32" ? "rules-cli.exe" : "rules-cli";
+
   // Create output directory
-  const outputDir = path.join('bin', `${platform}-${arch}`);
+  const outputDir = path.join("bin", `${platform}-${arch}`);
   if (!fs.existsSync(outputDir)) {
     fs.mkdirSync(outputDir, { recursive: true });
   }
-  
+
   const outputPath = path.join(outputDir, binaryName);
-  
+
   // Set environment variables for cross-compilation
   const env = {
     ...process.env,
-    GOOS: platform === 'win32' ? 'windows' : platform,
+    GOOS: platform === "win32" ? "windows" : platform,
     GOARCH: goarch,
-    CGO_ENABLED: '0'
+    CGO_ENABLED: "0",
   };
-  
+
   console.log(`Building for ${platform}-${arch}...`);
-  
+
   try {
     // Build the binary with version info
     execSync(
-      `go build -ldflags="-s -w -X main.Version=${version}" -o ${outputPath}`,
-      { env, stdio: 'inherit' }
+      `go build -ldflags="-s -w -X main.Version=${version} -X rules-cli/internal/utils.Version=${version}" -o ${outputPath}`,
+      { env, stdio: "inherit" }
     );
-    
+
     console.log(`Built ${outputPath}`);
-    
+
     // Make binary executable (not needed for Windows)
-    if (platform !== 'win32') {
-      fs.chmodSync(outputPath, '755');
+    if (platform !== "win32") {
+      fs.chmodSync(outputPath, "755");
     }
   } catch (error) {
     console.error(`Failed to build for ${platform}-${arch}: ${error.message}`);
     process.exit(1);
   }
 }
 
-console.log('Build completed successfully!');
+console.log("Build completed successfully!");

internal/utils/user_agent.go

@@ -6,16 +6,15 @@ import (
 	"runtime"
 )
 
+// Version will be set during build with ldflags
+var Version = "dev"
+
 // GetUserAgent returns the user agent string for HTTP requests
 // This includes the CLI name, version, and runtime information
 func GetUserAgent() string {
-	// For now, use a hardcoded version. In the future, this could be injected
-	// during the build process via ldflags
-	version := "1.0.0"
-	
 	// Include runtime information for better analytics
 	return fmt.Sprintf("rules-cli/%s (%s; %s; %s)", 
-		version, 
+		Version, 
 		runtime.GOOS, 
 		runtime.GOARCH, 
 		runtime.Version())

scripts/generate_golden.sh

@@ -31,7 +31,9 @@ trap cleanup EXIT
 
 # Build the latest version of the CLI
 echo -e "${GREEN}Building the CLI...${NC}"
-go build -o ./rules-cli
+# Get version from package.json
+VERSION=$(node -p "require('./package.json').version")
+go build -ldflags="-X main.Version=${VERSION} -X rules-cli/internal/utils.Version=${VERSION}" -o ./rules-cli
 
 # Copy the CLI to the temporary directory
 cp ./rules-cli "$TEMP_DIR/"

tests/golden_test.go

@@ -2,6 +2,7 @@ package tests
 
 import (
 	"bufio"
+	"fmt"
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -141,7 +142,15 @@ func TestGoldenFiles(t *testing.T) {
 	cliPath := "../rules-cli"
 	if _, err := os.Stat(cliPath); os.IsNotExist(err) {
 		// Build the CLI if it doesn't exist
-		cmd := exec.Command("go", "build", "-o", cliPath, "../main.go")
+		// Get version from package.json
+		versionCmd := exec.Command("node", "-p", "require('../package.json').version")
+		versionBytes, err := versionCmd.Output()
+		if err != nil {
+			t.Fatalf("Failed to get version from package.json: %v", err)
+		}
+		version := strings.TrimSpace(string(versionBytes))
+		
+		cmd := exec.Command("go", "build", "-ldflags", fmt.Sprintf("-X main.Version=%s -X rules-cli/internal/utils.Version=%s", version, version), "-o", cliPath, "../main.go")
 		if err := cmd.Run(); err != nil {
 			t.Fatalf("Failed to build CLI: %v", err)
 		}