Přidání CSS třídy sloupce na obsahové buňky tree-view#1291
Open
radimvaculik wants to merge 1 commit into
Open
Conversation
V tree-view se na obsahové buňky nepřidávala třída col-<sloupec>, kterou má hlavička. Doplněno col-{$column->getColumnName()}, aby hlavička i obsah byly konzistentní.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1291 +/- ##
=======================================
Coverage 48.77% 48.77%
=======================================
Files 61 61
Lines 2901 2901
=======================================
Hits 1415 1415
Misses 1486 1486 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popis
V tree-view (
datagrid_tree.latte) se na obsahové buňky pravého sloupcového bloku nepřidávala třídacol-<sloupec>, kterou má jejich hlavička. Kvůli tomu šlo cílit CSS na konkrétní sloupec jen přes:first-child,:last-child,:nth-childapod.Příčina
Nekonzistence mezi hlavičkou a obsahem v šabloně:
datagrid-tree-item-right-columns-column col-{\$column->getColumnName()} text-...→ např.col-statusdatagrid-tree-item-right-columns-column text-...→ třídacol-statuschybělaOprava
Doplněno
col-{\$column->getColumnName()}na obsahovou buňku, takže používá stejný výraz třídy jako hlavička.Closes #1290