Review and improve exception presentation#443
Merged
Conversation
…gative vs multi-digit values - Split error condition in ctindice(): i < 0 now shows "must be positive" (expected: ≥ 0), i > 9 shows "must be a single digit" with suggestion to use ctindices() - Split error condition in ctupperscript(): same pattern with ctupperscripts() suggestion - Updated tests to verify new error messages - All 90 tests in test/suite/unicode/ pass
Member
Author
|
This PR addresses the exception presentation review mentioned in #438. The goal is to systematically review and improve how exceptions are displayed in CTBase.jl, ensuring:
This will help users better understand and fix errors when they occur, especially for cases like |
- Refactored display.jl to use modular rendering functions - Added structured exception context display with sections - Improved error message formatting with clear hierarchy - Updated tests to cover new display behavior - Updated documentation in exceptions.md and index.md
…edesign Redesign exception display with improved formatting and structure
ocots
marked this pull request as ready for review
June 9, 2026 11:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR reviews and improves the presentation of exceptions in CTBase.jl, as identified in PR #438.
Tasks
showmethods for exceptions insrc/Exceptions/display.jlctindice(-1))Implementation
The exception display redesign has been implemented in PR #444. Key improvements:
│separatorsExtensionErrorbased onweakdepsContext
This work stems from PR #438 which mentions the need to review exception presentation. The goal is to ensure that error messages are clear, helpful, and consistent across the codebase.
Related