Add AbstractCache and make_coerce to CTBase.Core#459
Merged
Conversation
Move two generic, dependency-free building blocks out of CTFlows into CTBase.Core so they can be shared across the control-toolbox ecosystem: - `AbstractCache` (new `Core/caches.jl`): abstract base type for computation caches (e.g. prepared AD plans), with a generic docstring. - `make_coerce` (in `Core/function_utils.jl`): shape-matching coercion helper (`only` for scalars, `identity` for arrays). Both are exported from `Core`. `AbstractTag` already lived here, so the CTFlows duplicate is simply dropped on the consumer side. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves two generic, dependency-free building blocks out of CTFlows into
CTBase.Core, so they can be shared across the control-toolbox ecosystem.AbstractCache— newsrc/Core/caches.jl. Abstract base type for computation caches (pre-allocated buffers / prepared AD plans). Generic docstring (no CTFlows-specific references).make_coerce— added tosrc/Core/function_utils.jl, next toto_out_of_place/matrix2vec. Shape-matching coercion helper:onlyfor scalars,identityfor arrays.Both are exported from
Core.AbstractTagalready lives inCore/tags.jl, so no new tag type is added here — the CTFlows duplicate is dropped on the consumer side.Context
This is the first step (phase A) of moving generic utilities from CTFlows into CTBase. Companion consumer PR in CTFlows.jl rewires
CTFlows.Commonto re-export these fromCTBase.Coreand removes the duplicated files. That CTFlows PR depends on this one being merged and a CTBase0.21beta being available.Later phases (separate PRs) will move the
TraitsandDatamodules.Test plan
using CTBaseloads;CTBase.Core.AbstractCache,CTBase.Core.make_coercebehave as expected.🤖 Generated with Claude Code