refactor!: move NotProvided/NotProvidedType to Core, remove from Options (0.25.0-beta)#468
Merged
Merged
Conversation
…ons) NotProvidedType and NotProvided are now defined and exported ONLY from CTBase.Core as the canonical ecosystem-wide sentinel. They are removed from CTBase.Options (no re-export): Options.NotProvided / Options.NotProvidedType no longer exist. - Options/not_provided.jl renamed to not_stored.jl (keeps NotStored only). - Internal Options/extraction + option_definition reference Core.NotProvidedType. - Tests repointed to Core.NotProvided. BREAKING: replace Options.NotProvided -> Core.NotProvided. Bump 0.25.0-beta. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ocots
force-pushed
the
refactor/notprovided-to-core
branch
from
June 26, 2026 11:11
bf440f6 to
defd8ac
Compare
ocots
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotProvidedTypeandNotProvidedare now defined and exported only fromCTBase.Core(canonical ecosystem-wide sentinel).CTBase.Options— no re-export.CTBase.Options.NotProvided/CTBase.Options.NotProvidedTypeno longer exist.Options/not_provided.jlrenamed →not_stored.jl(keeps the extraction-internalNotStored/NotStoredTypeonly).Core.NotProvidedTypedirectly.Replace
Options.NotProvided→Core.NotProvided(andOptions.NotProvidedType→Core.NotProvidedType). SeeBREAKINGS.md.Downstream follow-ups (separate PRs): CTModels (compat widen), CTSolvers (
Options.NotProvided→Core.NotProvided), CTFlows (Options.NotProvided→Core.NotProvided+ useCore.NotProvidedfor the variable sentinel).Test plan
test_options.jlasserts NotProvided is in Core and not in Options🤖 Generated with Claude Code