Remove build_ad_backend convenience factory and no-arg __ad_backend()#502
Merged
Conversation
- Delete src/Differentiation/building.jl (contained only build_ad_backend)
- Remove build_ad_backend from Differentiation module: include, export, docstring
- Remove no-arg __ad_backend() from default.jl; keep parameterized
__ad_backend(::Type{CPU}) and __ad_backend(::Type{GPU})
- Update tests: remove build_ad_backend and __ad_backend testsets,
replace call sites with DifferentiationInterface()
- Rewrite docs/guide/differentiation.md 'Building a backend' section
with real DifferentiationInterface() constructions
- Remove building.jl from docs/api_reference.jl file list
- Update .devin/workflows/plan.md references (3 occurrences)
- Bump version 0.28.2-beta -> 0.28.3-beta
- Update CHANGELOG.md and BREAKING.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
build_ad_backendconvenience factory — a trivial one-line wrapper aroundDifferentiationInterface(; kwargs...)— and the no-arg__ad_backend()default (superseded by parameterized__ad_backend(::Type{CPU})/__ad_backend(::Type{GPU})).Changes
Source
src/Differentiation/building.jl(contained onlybuild_ad_backend)src/Differentiation/Differentiation.jl: removeinclude,export, and docstring entrysrc/Differentiation/default.jl: remove no-arg__ad_backend()+ docstring; keep parameterized variantsTests
test_ad_backend.jl: removed"Unit: build_ad_backend"and"Unit: __ad_backend default"testsetstest_arg_placement.jl:_default_backend()now callsDifferentiationInterface()directlytest_differentiation_module.jl: removed:build_ad_backendfromEXPORTED_FUNCTIONSDocs & workflow
docs/src/guide/differentiation.md: "Building a backend" section rewritten with realDifferentiationInterface()constructionsdocs/api_reference.jl: removedbuilding.jlfrom file list.devin/workflows/plan.md: 3build_ad_backend→DifferentiationInterfacereplacementsRelease
Project.toml: version bump0.28.2-beta→0.28.3-betaCHANGELOG.md: new## [0.28.3-beta]entryBREAKING.md: new non-breaking note for0.28.3-betaTest results
All 106 differentiation tests pass.
Breaking change?
No breaking change in practice:
build_ad_backendwas not used anywhere in the ecosystem. Callers replacebuild_ad_backend(; kwargs...)→DifferentiationInterface(; kwargs...).