Conversation
Contributor
|
Breakage test results
|
Complete migration to CTBase exception system with 100% test success Changes: - ExtensionError for serialization stubs (JLD2/JSON3) - NotImplemented: type_info → required_method (19 occurrences) - IncorrectArgument enriched with contextual fields (8 occurrences) - 31 source files updated across all modules - 45 test files updated with proper exception prefixes - 4213 tests passing (100% success rate)
- Phase 2: Copy 6 modules (Options, Strategies, Orchestration, Optimization, Modelers, DOCP) to migration_to_ctsolvers/ - Phase 3: Adapt CTModels to work without migrated modules - Remove dependencies on ADNLPModels, ExaModels, MadNLP, NLPModels, SolverCore - Update CTModels.jl to only load core modules (Utils, OCP, Display, Serialization, InitialGuess) - Remove imports from Optimization in OCP.jl - Simplify TestProblems to only include Beam, solution_example, solution_example_dual - Update runtests.jl to remove migrated package dependencies - Update Project.toml for CTModels 0.8.0-beta with minimal dependencies - Preserve CTBase.Exceptions compatibility - All CTModels core functionality remains intact (tests + documentation ready) Migration ready for CTSolvers integration
…tion - Update make.jl: simplify structure (Introduction + API Reference only) - Rewrite api_reference.jl: use new CTBase.automatic_reference_documentation API - Update index.md: clarify CTModels role (problem definition) vs CTSolvers (solving) - Document remaining modules: Utils, OCP, Display, Serialization, InitialGuess - Add conditional documentation for extensions: Plots, JSON, JLD2 - Remove references to migrated modules (DOCP, Modelers, Optimization, Options, Orchestration, Strategies)
- Add external_modules_to_document parameter to OCP sections in api_reference.jl - Set warnonly=[:cross_references] in make.jl to allow build with warnings - Fix syntax error (semicolon -> comma) in api_reference.jl - Documentation now builds successfully with warnings instead of errors
- Add comprehensive docstring for build_model() following project standards - Integrate extensions (Plots, JSON, JLD2) into main API documentation - Remove separate extension documentation pages for better organization - Clean up generated API files and old documentation - Update docs/Project.toml dependencies (remove CTModels circular dependency) - Export plot/plot! from CTModelsPlots extension - Simplify make.jl by removing package activation (handled externally) - Documentation builds successfully with only minor time_ns warning All tests pass (3135/3135) and documentation generates without errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.