corrected control_fun -> :control_fun when matching constraint type#198
Closed
jbcaillau wants to merge 3 commits into
Closed
corrected control_fun -> :control_fun when matching constraint type#198jbcaillau wants to merge 3 commits into
jbcaillau wants to merge 3 commits into
Conversation
Contributor
|
Breakage test results
|
- Add comprehensive tests for :other constraint type errors in test_onepass_fun_bis.jl and test_onepass_exa_bis.jl * Unit tests for p_constraint_fun!/p_constraint_exa! with :other type * Integration tests using @def and @def_exa macros for invalid constraints * Tests cover mixed state/control at different times (e.g., x(0)*u(t)+u(t)^2 <= 1) - Fix incorrect superscript exponents in test_onepass_fun.jl * Replace r²(__s) with (r^2)(__s) in lines 760 and 854 * Ensures proper aliasing for exponentiated variables - Update as_range tests in test_onepass_exa_bis.jl * Reflect new implementation returning :(($x):($x)) instead of [x] 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Correct test from :((:foo):(:foo)) to :(foo:foo) - The implementation :(($x):($x)) interpolates x directly, producing :(foo:foo) - The previous test with nested quotes was incorrect 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
Author
|
merged into #182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x1(0) * u1(t)^2 + ...(not mixed but previously accepted as control_fun!)