Skip to content

add SciMLSensitivity#458

Merged
jbcaillau merged 11 commits intomainfrom
457-dev-fix-goddard-tuto-in-doc-for-100
Apr 17, 2025
Merged

add SciMLSensitivity#458
jbcaillau merged 11 commits intomainfrom
457-dev-fix-goddard-tuto-in-doc-for-100

Conversation

@ocots
Copy link
Copy Markdown
Member

@ocots ocots commented Apr 17, 2025

No description provided.

@ocots ocots linked an issue Apr 17, 2025 that may be closed by this pull request
@ocots ocots marked this pull request as draft April 17, 2025 19:35
@jbcaillau
Copy link
Copy Markdown
Member

jbcaillau commented Apr 17, 2025

@ocots for Goddard and ISS:

  • also added try ... catch for NonlinearSolve.solve calls (and defined nlsolve instead of redefining NonlinearSolve.solve - guess i need to import first...) actually, only NewtonRaphson seems to work
  • removed computations / solution extraction from NonlinearSolve as in any case these results will be provided by MINPACK.fsolve
  • removed "gradient preparation" from Diffinterface before calling MINPACK (generates an error...)

@jbcaillau
Copy link
Copy Markdown
Member

@ocots looks like with your patch that falls back to MINPACK hybrd when hybrj fails, everything should be OK for your local runs on MacOS: correct?

the case being, given the issues with NonlinearSolve, i suggest to keep only MINPACK (without the "preparation" for DiffInterface that doesn't seem to work anymore).

@jbcaillau jbcaillau marked this pull request as ready for review April 17, 2025 23:32
@jbcaillau jbcaillau merged commit 9e263b7 into main Apr 17, 2025
5 checks passed
@ocots ocots deleted the 457-dev-fix-goddard-tuto-in-doc-for-100 branch April 18, 2025 08:35
@ocots ocots mentioned this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev] fix goddard tuto in doc for 1.0.0

2 participants