Skip to content

upgraded CTDirect to v0.17#635

Merged
jbcaillau merged 11 commits intomainfrom
634-dev-new-release
Sep 24, 2025
Merged

upgraded CTDirect to v0.17#635
jbcaillau merged 11 commits intomainfrom
634-dev-new-release

Conversation

@jbcaillau
Copy link
Copy Markdown
Member

@jbcaillau jbcaillau commented Sep 20, 2025 •
edited
Loading

close #634

@jbcaillau jbcaillau requested a review from ocots September 20, 2025 15:12
@jbcaillau jbcaillau linked an issue Sep 20, 2025 that may be closed by this pull request
[Dev] new release #634
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 20, 2025 •
edited
Loading

Breakage test results
Date: 2025-09-23 18:25:27

Name Latest Stable
OptimalControlProblems.jl

@jbcaillau
Copy link
Copy Markdown
Member Author

jbcaillau commented Sep 20, 2025

@ocots i might be doing sth stupid but

@ocots
Copy link
Copy Markdown
Member

ocots commented Sep 20, 2025 •
edited
Loading

I was working on another branch updating CTDirect compat. I merge in this branch.

This was referenced Sep 20, 2025
Closed
Merged
@ocots
Copy link
Copy Markdown
Member

ocots commented Sep 20, 2025 •
edited
Loading

CTDirect.model does not exist anymore. We have CTDirect.ocp_model and CTDirect.nlp_model. We need docstrings for them to make the doc.

See control-toolbox/CTDirect.jl#501.

@ocots ocots mentioned this pull request Sep 20, 2025
Closed
@jbcaillau
Copy link
Copy Markdown
Member Author

jbcaillau commented Sep 21, 2025 •
edited
Loading

CTDirect.model does not exist anymore. We have CTDirect.ocp_model and CTDirect.nlp_model. We need docstrings for them to make the doc.

See control-toolbox/CTDirect.jl#501.

@ocots my bad. CTDirect.model indeed 👍🏽

but is it only a doc issue? i suppose that these models are indeed used somewhere in OptimalControl.jl (and in OptimalControlProblems.jl)

@ocots
Copy link
Copy Markdown
Member

ocots commented Sep 21, 2025

CTDirect.model does not exist anymore. We have CTDirect.ocp_model and CTDirect.nlp_model. We need docstrings for them to make the doc.
See control-toolbox/CTDirect.jl#501.

@ocots my bad. CTDirect.model indeed 👍🏽

but is it only a doc issue? i suppose that these models are indeed used somewhere in OptimalControl.jl (and in OptimalControlProblems.jl)

They are used in OptimalControlProblems.jl.

jbcaillau
jbcaillau commented Sep 21, 2025
View reviewed changes
Comment thread src/OptimalControl.jl
import CTDirect:
CTDirect, direct_transcription, set_initial_guess, build_OCP_solution, model
export direct_transcription, set_initial_guess, build_OCP_solution, model
CTDirect, direct_transcription, set_initial_guess, build_OCP_solution, nlp_model, ocp_model
Copy link
Copy Markdown
Member Author

@jbcaillau jbcaillau Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ocots

@ocots ocots marked this pull request as draft September 23, 2025 15:34
@ocots
Copy link
Copy Markdown
Member

ocots commented Sep 23, 2025

Warning

Waiting for exa midpoint before merging.

@jbcaillau
Copy link
Copy Markdown
Member Author

jbcaillau commented Sep 23, 2025 •
edited
Loading

@PierreMartinon @ocots control-toolbox/CTParser.jl#94 (comment) 🤞🏽

Warning

Waiting for exa midpoint before merging.

@jbcaillau jbcaillau marked this pull request as ready for review September 24, 2025 23:17
jbcaillau
jbcaillau commented Sep 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@jbcaillau jbcaillau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge

@jbcaillau jbcaillau merged commit 3ece8a2 into main Sep 24, 2025
5 of 14 checks passed
@jbcaillau jbcaillau deleted the 634-dev-new-release branch September 24, 2025 23:19
@jbcaillau jbcaillau mentioned this pull request Sep 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocots ocots Awaiting requested review from ocots

Assignees

@ocots ocots

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Dev] new release

2 participants

@jbcaillau @ocots